[webkit-changes] [WebKit/WebKit] 41dcd0: Drop MessageName::Terminate IPC message

Chris Dumez noreply at github.com
Mon Jul 31 11:32:20 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 41dcd0b76687719b14a4f34c155deb15f05772cb
      https://github.com/WebKit/WebKit/commit/41dcd0b76687719b14a4f34c155deb15f05772cb
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-07-31 (Mon, 31 Jul 2023)

  Changed paths:
    M Source/WebKit/Platform/IPC/Connection.cpp
    M Source/WebKit/Scripts/webkit/model.py
    M Source/WebKit/Scripts/webkit/tests/MessageNames.cpp
    M Source/WebKit/Scripts/webkit/tests/MessageNames.h
    M Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp

  Log Message:
  -----------
  Drop MessageName::Terminate IPC message
https://bugs.webkit.org/show_bug.cgi?id=256373
rdar://108899132

Reviewed by Sihui Liu.

Drop MessageName::Terminate IPC message as it could easily be abused by a
compromised WebProcess to kill the UIProcess.

It was temporarily introduced in 243810 at main to investigate NetworkProcess
hangs we were seeing and should no longer be needed. This reverts 243810 at main.

* Source/WebKit/Platform/IPC/Connection.cpp:
(IPC::Connection::processIncomingMessage):
(IPC::terminateDueToIPCTerminateMessage): Deleted.
* Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::didBecomeUnresponsive):
(WebKit::shouldTerminateNetworkProcessBySendingMessage): Deleted.

Originally-landed-as: 259548.751 at safari-7615-branch (9fc652968e3c). rdar://108899132
Canonical link: https://commits.webkit.org/266446@main




More information about the webkit-changes mailing list