[webkit-changes] [WebKit/WebKit] 57717f: 'hr' with width as 0 or 0px get 1px

Ahmad Saleem noreply at github.com
Sat Jul 29 16:04:40 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 57717fd0d5abf106eddd9881f3eb8efbd3957f92
      https://github.com/WebKit/WebKit/commit/57717fd0d5abf106eddd9881f3eb8efbd3957f92
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-07-29 (Sat, 29 Jul 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/html/rendering/dimension-attributes-expected.txt
    M Source/WebCore/html/HTMLHRElement.cpp

  Log Message:
  -----------
  'hr' with width as 0 or 0px get 1px

https://bugs.webkit.org/show_bug.cgi?id=259620

Reviewed by Simon Fraser.

Prior to this patch, WebKit used to return 1px as width length even if it is
configured as `hr width=0` or `hr width=0px`, which is not correct. Only
Gecko / Firefox, return expected '0' properly. This patch will align WebKit
with Gecko / Firefox and correctly return 0px for above cases.

* Source/WebCore/html/HTMLHRElement.cpp:
(HTMLHRElement::collectPresentationalHintsForAttribute): For 'widthAttr' return 0px instead of 1px
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/dimension-attributes-expected.txt: Rebaselined

Canonical link: https://commits.webkit.org/266418@main




More information about the webkit-changes mailing list