[webkit-changes] [WebKit/WebKit] 529036: VO interacts with the element containing the app s...

[AndresGonzalezApple]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 52903644b8d383e5387b99def25b6bea3f6738a7
      https://github.com/WebKit/WebKit/commit/52903644b8d383e5387b99def25b6bea3f6738a7
  Author: Andres Gonzalez <andresg_22 at apple.com>
  Date:   2023-07-29 (Sat, 29 Jul 2023)

  Changed paths:
    M LayoutTests/accessibility/text-marker/text-marker-range-with-unordered-markers-expected.txt
    M LayoutTests/accessibility/text-marker/text-marker-range-with-unordered-markers.html
    A LayoutTests/platform/glib/accessibility/text-marker/text-marker-range-with-unordered-markers-expected.txt
    A LayoutTests/platform/ios/accessibility/text-marker/text-marker-range-with-unordered-markers-expected.txt
    M LayoutTests/platform/mac-wk1/TestExpectations
    M Source/WebCore/accessibility/AXTextMarker.cpp
    M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
    M Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp
    M Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h
    M Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl
    M Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm

  Log Message:
  -----------
  VO interacts with the element containing the app selection instead of with VO's current element.
https://bugs.webkit.org/show_bug.cgi?id=259629
rdar://112193520

Reviewed by Chris Fleizach.

VoiceOver uses the AXTextMarkerRangeForUnorderedTextMarkersAttribute to decide which element to interact with when the user presses VO Shift Down Arrow. This API failed when one of the TextMarker parameters was created off the main thread and thus has a null Node*. This patch fixes the issue by having a single implementation for both AXTextMarkerRangeForUnorderedTextMarkers and AXTextMarkerRangeForTextMarkers that supports unordered TextMarkers.

Added WTR::AccessibilityUIElement::textMarkerRangeForUnorderedMarkers and a test case for this API.

* LayoutTests/accessibility/text-marker/text-marker-range-with-unordered-markers-expected.txt:
* LayoutTests/accessibility/text-marker/text-marker-range-with-unordered-markers.html:
* LayoutTests/platform/glib/accessibility/text-marker/text-marker-range-with-unordered-markers-expected.txt: Added.
* LayoutTests/platform/ios/accessibility/text-marker/text-marker-range-with-unordered-markers-expected.txt: Added.
* LayoutTests/platform/mac-wk1/TestExpectations:
* Source/WebCore/accessibility/AXTextMarker.cpp:
(WebCore::partialOrder):
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
* Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::textMarkerRangeForUnorderedMarkers):
* Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
* Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
* Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::textMarkerRangeForUnorderedMarkers):

Canonical link: https://commits.webkit.org/266417@main