[webkit-changes] [WebKit/WebKit] e1cc9f: [Tables] Do not try to invalidate columns when the...
Alan Baradlay
noreply at github.com
Wed Jul 26 17:59:22 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e1cc9fc57dbed8960204db019c66524bd33f39b4
https://github.com/WebKit/WebKit/commit/e1cc9fc57dbed8960204db019c66524bd33f39b4
Author: Alan Baradlay <zalan at apple.com>
Date: 2023-07-26 (Wed, 26 Jul 2023)
Changed paths:
A LayoutTests/fast/table/table-inside-continuation-removed-expected.txt
A LayoutTests/fast/table/table-inside-continuation-removed.html
M Source/WebCore/rendering/RenderTable.cpp
M Source/WebCore/rendering/RenderTable.h
M Source/WebCore/rendering/RenderTableCol.cpp
Log Message:
-----------
[Tables] Do not try to invalidate columns when the entire table is being destroyed
https://bugs.webkit.org/show_bug.cgi?id=259531
<rdar://111803504>
Reviewed by Ryosuke Niwa.
Subtree teardown logic with anonymous root (e.g. continuation) has a parent -> child direction as opposed to the regular teardown direction which is child -> parent.
In case when we run top-bottom teardown, we don't have to invalidate the column cache as the table is being destroyed as well.
* LayoutTests/fast/table/table-inside-continuation-removed-expected.txt: Added.
* LayoutTests/fast/table/table-inside-continuation-removed.html: Added.
* Source/WebCore/rendering/RenderTable.cpp:
(WebCore::RenderTable::invalidateColumns):
(WebCore::RenderTable::removeColumn): Deleted.
* Source/WebCore/rendering/RenderTable.h:
* Source/WebCore/rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::willBeRemovedFromTree):
Canonical link: https://commits.webkit.org/266344@main
More information about the webkit-changes
mailing list