[webkit-changes] [WebKit/WebKit] e68eac: Disable builtInNotification endpoints when builtIn...

Gavin noreply at github.com
Wed Jul 26 03:54:36 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e68eac0ee93ab3d5f87e6bad5e063c86508511da
      https://github.com/WebKit/WebKit/commit/e68eac0ee93ab3d5f87e6bad5e063c86508511da
  Author: Gavin Phillips <gavin.p at apple.com>
  Date:   2023-07-26 (Wed, 26 Jul 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    A LayoutTests/ipc/restrictedendpoints/deny-access-webPush.html
    M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
    M Source/WebKit/NetworkProcess/NetworkProcess.cpp
    M Source/WebKit/NetworkProcess/NetworkProcess.h
    M Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h
    M Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.serialization.in
    M Source/WebKit/NetworkProcess/NetworkSession.cpp
    M Source/WebKit/Shared/Notifications/NotificationManagerMessageHandler.h
    M Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp

  Log Message:
  -----------
  Disable builtInNotification endpoints when builtInNotificationsEnabled is set to false
https://bugs.webkit.org/show_bug.cgi?id=259443
rdar://112769420

Reviewed by Alex Christensen.

When builtInNotificationsEnabled is set to false, we don't need to expose the
endpoints associated with the feature. This change syncs the feature state to the
network process and checks the endpoints is only reached when it's enabled.

* LayoutTests/TestExpectations:
* LayoutTests/ipc/restrictedendpoints/deny-access-webPush.html: Added.
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::didReceiveMessage):
* Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::initializeNetworkProcess):
* Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h:
* Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.serialization.in:
* Source/WebKit/NetworkProcess/NetworkSession.cpp:
(WebKit::m_shouldAcceptInsecureCertificatesForWebSockets):
* Source/WebKit/Shared/Notifications/NotificationManagerMessageHandler.h:
* Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::sendCreationParametersToNewProcess):

Canonical link: https://commits.webkit.org/266312@main




More information about the webkit-changes mailing list