[webkit-changes] [WebKit/WebKit] 2d36f4: Support title attribute for pattern validation errors

Anne van Kesteren noreply at github.com
Wed Jul 26 01:16:50 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2d36f436ba4efb45b5e3f3826637e671c9b13eaa
      https://github.com/WebKit/WebKit/commit/2d36f436ba4efb45b5e3f3826637e671c9b13eaa
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2023-07-26 (Wed, 26 Jul 2023)

  Changed paths:
    M LayoutTests/fast/forms/validation-messages-expected.txt
    M LayoutTests/fast/forms/validation-messages.html
    M LayoutTests/platform/ios-wk2/fast/forms/validation-messages-expected.txt
    M Source/WebCore/en.lproj/Localizable.strings
    M Source/WebCore/html/InputType.cpp
    M Source/WebCore/platform/LocalizedStrings.cpp
    M Source/WebCore/platform/LocalizedStrings.h

  Log Message:
  -----------
  Support title attribute for pattern validation errors
https://bugs.webkit.org/show_bug.cgi?id=258301
rdar://111394402

Reviewed by Aditya Keerthi.

The HTML Standard suggests that the title attribute can be used to
augment the message presented to the end user. As this is not trusted
UI space this seems reasonable (JavaScript has full control over this
UI) and also matches other browsers.

* LayoutTests/fast/forms/validation-messages-expected.txt:
* LayoutTests/fast/forms/validation-messages.html:
* LayoutTests/platform/ios-wk2/fast/forms/validation-messages-expected.txt:
* Source/WebCore/en.lproj/Localizable.strings:
* Source/WebCore/html/InputType.cpp:
(WebCore::InputType::validationMessage const):
* Source/WebCore/platform/LocalizedStrings.cpp:
(WebCore::validationMessagePatternMismatchText):
* Source/WebCore/platform/LocalizedStrings.h:

Canonical link: https://commits.webkit.org/266311@main




More information about the webkit-changes mailing list