[webkit-changes] [WebKit/WebKit] 2b3728: AX: Stop unnecessarily caching AXPropertyName::Tab...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2b3728c778ae918e5c9e5b72a6af1ac2951c7d10
      https://github.com/WebKit/WebKit/commit/2b3728c778ae918e5c9e5b72a6af1ac2951c7d10
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2023-07-21 (Fri, 21 Jul 2023)

  Changed paths:
    M Source/WebCore/accessibility/AccessibilityObject.h
    M Source/WebCore/accessibility/AccessibilityObjectInterface.h
    M Source/WebCore/accessibility/AccessibilityTable.cpp
    M Source/WebCore/accessibility/AccessibilityTable.h
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h

  Log Message:
  -----------
  AX: Stop unnecessarily caching AXPropertyName::TableLevel
https://bugs.webkit.org/show_bug.cgi?id=259346
rdar://problem/112555093

Reviewed by Chris Fleizach.

We can express AXPropertyName::TableLevel purely in the form of existing
AXCoreObject functions, so there is no need to cache it separately. This
improves up-front object creation speed, reduces memory consumption, and
improves correctness, as a property that is not cached cannot become
out-of-date.

* Source/WebCore/accessibility/AccessibilityObject.h:
* Source/WebCore/accessibility/AccessibilityObjectInterface.h:
(WebCore::AXCoreObject::tableLevel const):
* Source/WebCore/accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::tableLevel const): Deleted.
* Source/WebCore/accessibility/AccessibilityTable.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeProperties):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:

Canonical link: https://commits.webkit.org/266213@main