[webkit-changes] [WebKit/WebKit] 12967a: AX: Fix 15 tests in ITM mode

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 12967a33fb8790b61338331bbf34397546aa75f3
      https://github.com/WebKit/WebKit/commit/12967a33fb8790b61338331bbf34397546aa75f3
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2023-07-21 (Fri, 21 Jul 2023)

  Changed paths:
    M LayoutTests/accessibility-isolated-tree/TestExpectations
    M LayoutTests/accessibility/mac/aria-tree.html
    M LayoutTests/accessibility/mac/crash-invalid-text-marker-node-expected.txt
    M LayoutTests/accessibility/mac/crash-invalid-text-marker-node.html
    M LayoutTests/accessibility/mac/test-convenience-methods-expected.txt
    M LayoutTests/accessibility/mac/test-convenience-methods.html
    M LayoutTests/accessibility/scroll-to-global-point-iframe-expected.txt
    M LayoutTests/accessibility/scroll-to-global-point-iframe-nested-expected.txt
    M LayoutTests/accessibility/scroll-to-global-point-iframe-nested.html
    M LayoutTests/accessibility/scroll-to-global-point-iframe.html
    M LayoutTests/accessibility/scroll-to-global-point-main-window-expected.txt
    M LayoutTests/accessibility/scroll-to-global-point-main-window.html
    M LayoutTests/accessibility/scroll-to-global-point-nested-expected.txt
    M LayoutTests/accessibility/scroll-to-global-point-nested.html
    M LayoutTests/accessibility/scroll-to-make-visible-div-overflow-expected.txt
    M LayoutTests/accessibility/scroll-to-make-visible-div-overflow.html
    M LayoutTests/accessibility/scroll-to-make-visible-iframe-expected.txt
    M LayoutTests/accessibility/scroll-to-make-visible-iframe-offscreen-expected.txt
    M LayoutTests/accessibility/scroll-to-make-visible-iframe-offscreen.html
    M LayoutTests/accessibility/scroll-to-make-visible-iframe.html
    M LayoutTests/accessibility/scroll-to-make-visible-nested-2-expected.txt
    M LayoutTests/accessibility/scroll-to-make-visible-nested-2.html
    M LayoutTests/accessibility/scroll-to-make-visible-nested-expected.txt
    M LayoutTests/accessibility/scroll-to-make-visible-nested.html
    M LayoutTests/accessibility/scroll-to-make-visible-with-subfocus-expected.txt
    M LayoutTests/accessibility/scroll-to-make-visible-with-subfocus.html
    M LayoutTests/accessibility/textarea-insertion-point-line-number-expected.txt
    M LayoutTests/accessibility/textarea-insertion-point-line-number.html
    M Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm

  Log Message:
  -----------
  AX: Fix 15 tests in ITM mode
https://bugs.webkit.org/show_bug.cgi?id=259392
rdar://problem/112657426

Reviewed by Andres Gonzalez.

This patch fixes 15 tests for ITM. The bulk of these are scrolling tests, which needed to be made async. There was also
a bug in AccessibilityUIElement::scrollToGlobalPoint and AccessibilityUIElement::scrollToMakeVisibleWithSubFocus where
they passed the memory address of a stack variable from the main-thread to the secondary thread. I would’ve expected
this to have caused a crash, but instead it seems to just do the wrong thing and default-initialize the value. So if
we tried to scroll to NSPoint(0, 300), we were always scrolling to NSPoint(0, 0).

This patch addresses this by copying the necessary values into the lambda, rather than taking them by reference.

Several other non-scrolling AX tests are also made async, allowing them to pass with no other code changes.

* LayoutTests/accessibility-isolated-tree/TestExpectations:
* LayoutTests/accessibility/mac/aria-tree.html:
* LayoutTests/accessibility/mac/crash-invalid-text-marker-node-expected.txt:
* LayoutTests/accessibility/mac/crash-invalid-text-marker-node.html:
* LayoutTests/accessibility/mac/test-convenience-methods-expected.txt:
* LayoutTests/accessibility/mac/test-convenience-methods.html:
* LayoutTests/accessibility/scroll-to-global-point-iframe-expected.txt:
* LayoutTests/accessibility/scroll-to-global-point-iframe-nested-expected.txt:
* LayoutTests/accessibility/scroll-to-global-point-iframe-nested.html:
* LayoutTests/accessibility/scroll-to-global-point-iframe.html:
* LayoutTests/accessibility/scroll-to-global-point-main-window-expected.txt:
* LayoutTests/accessibility/scroll-to-global-point-main-window.html:
* LayoutTests/accessibility/scroll-to-global-point-nested-expected.txt:
* LayoutTests/accessibility/scroll-to-global-point-nested.html:
* LayoutTests/accessibility/scroll-to-make-visible-div-overflow-expected.txt:
* LayoutTests/accessibility/scroll-to-make-visible-div-overflow.html:
* LayoutTests/accessibility/scroll-to-make-visible-iframe-expected.txt:
* LayoutTests/accessibility/scroll-to-make-visible-iframe-offscreen-expected.txt:
* LayoutTests/accessibility/scroll-to-make-visible-iframe-offscreen.html:
* LayoutTests/accessibility/scroll-to-make-visible-iframe.html:
* LayoutTests/accessibility/scroll-to-make-visible-nested-2-expected.txt:
* LayoutTests/accessibility/scroll-to-make-visible-nested-2.html:
* LayoutTests/accessibility/scroll-to-make-visible-nested-expected.txt:
* LayoutTests/accessibility/scroll-to-make-visible-nested.html:
* LayoutTests/accessibility/scroll-to-make-visible-with-subfocus-expected.txt:
* LayoutTests/accessibility/scroll-to-make-visible-with-subfocus.html:
* LayoutTests/accessibility/textarea-insertion-point-line-number-expected.txt:
* LayoutTests/accessibility/textarea-insertion-point-line-number.html:
* Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::scrollToGlobalPoint):
(WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):

Canonical link: https://commits.webkit.org/266212@main