[webkit-changes] [WebKit/WebKit] 68a63d: Special-casing the zero glyph page is unnecessary ...

Myles C. Maxfield noreply at github.com
Sun Jul 16 14:24:46 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 68a63d5baeafd9de8dbd0f8301946a383e2d0e3d
      https://github.com/WebKit/WebKit/commit/68a63d5baeafd9de8dbd0f8301946a383e2d0e3d
  Author: Myles C. Maxfield <mmaxfield at apple.com>
  Date:   2023-07-16 (Sun, 16 Jul 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/Font.cpp
    M Source/WebCore/platform/graphics/Font.h

  Log Message:
  -----------
  Special-casing the zero glyph page is unnecessary (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=259257
rdar://112344047

Reviewed by Cameron McCormack.

This is a follow-up to 266052 at main. Each glyph page only holds 16 characters, so the
0th glyph page isn't really special. Almost no text will actually use it. So there's
no need to special-case it. (I bet that this special-case wasn't actually created
for performance, but just because of how our HashMaps treat 0 as empty...)

* Source/WebCore/platform/graphics/Font.cpp:
(WebCore::Font::glyphPage const):
* Source/WebCore/platform/graphics/Font.h:

Canonical link: https://commits.webkit.org/266091@main




More information about the webkit-changes mailing list