[webkit-changes] [WebKit/WebKit] 359976: Improve how to serialize fulfilled promise status

cybai (Haku) noreply at github.com
Fri Jul 14 00:44:39 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 359976cda05e9714df3462327e2b3d0fc8527649
      https://github.com/WebKit/WebKit/commit/359976cda05e9714df3462327e2b3d0fc8527649
  Author: Cheng-You Bai <cyb.ai.815 at gmail.com>
  Date:   2023-07-14 (Fri, 14 Jul 2023)

  Changed paths:
    M LayoutTests/inspector/model/remote-object/promise-expected.txt
    M LayoutTests/inspector/runtime/getDisplayableProperties-expected.txt
    M LayoutTests/inspector/runtime/getProperties-expected.txt
    M Source/JavaScriptCore/inspector/JSInjectedScriptHost.cpp

  Log Message:
  -----------
  Improve how to serialize fulfilled promise status
https://bugs.webkit.org/show_bug.cgi?id=225328

Reviewed by Patrick Angle.

While the `[[PromiseStatus]]` enum matches the spec to have `fulfilled`
status, WebKit is translating it to `resolved` which doesn't match the
spec[1]. Thus, this commit will make `fulfilled` status to be serialized
as `fulfilled` instead of `resolved`.

[1]: https://tc39.es/ecma262/#sec-properties-of-promise-instances

* LayoutTests/inspector/model/remote-object/promise-expected.txt:
* LayoutTests/inspector/runtime/getDisplayableProperties-expected.txt:
* LayoutTests/inspector/runtime/getProperties-expected.txt:
* Source/JavaScriptCore/inspector/JSInjectedScriptHost.cpp:
(Inspector::JSInjectedScriptHost::getInternalProperties):

Canonical link: https://commits.webkit.org/266058@main




More information about the webkit-changes mailing list