[webkit-changes] [WebKit/WebKit] e51b17: Fix Windows port clang-cl warnings for WebKit and ...

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e51b17e2f6135304d65a02193e1d5acd59a9ffc4
      https://github.com/WebKit/WebKit/commit/e51b17e2f6135304d65a02193e1d5acd59a9ffc4
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2023-07-13 (Thu, 13 Jul 2023)

  Changed paths:
    M Source/WebKit/GPUProcess/graphics/wc/RemoteWCLayerTreeHost.cpp
    M Source/WebKit/NetworkProcess/cache/NetworkCache.cpp
    M Source/WebKit/NetworkProcess/curl/WebSocketTaskCurl.h
    M Source/WebKit/Shared/win/WebEventFactory.h
    M Source/WebKit/UIProcess/Inspector/socket/RemoteInspectorClient.cpp
    M Tools/MiniBrowser/win/MainWindow.cpp
    M Tools/TestWebKitAPI/Tests/WTF/StdLibExtrasTests.cpp
    M Tools/TestWebKitAPI/Tests/WebCore/FloatRectTests.cpp
    M Tools/TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp

  Log Message:
  -----------
  Fix Windows port clang-cl warnings for WebKit and Tools
https://bugs.webkit.org/show_bug.cgi?id=259206

Reviewed by Yusuke Suzuki.

clang-cl reported the following warnings for Windows port WebKit and Tools:

include\memory(3167,9): warning: delete called on non-final 'WebKit::WebSocketTask' that has virtual functions but non-virtual destructor [-Wdelete-non-abstract-non-virtual-dtor]
include\memory(3167,9): warning: delete called on non-final 'WebKit::WebSocketTask' that has virtual functions but non-virtual destructor [-Wdelete-non-abstract-non-virtual-dtor]
Source\WebKit\GPUProcess\graphics\wc\RemoteWCLayerTreeHost.cpp(103,35): warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
Source\WebKit\NetworkProcess/cache/NetworkCache.cpp(415,253): warning: lambda capture 'isNavigatingToAppBoundDomain' is not used [-Wunused-lambda-capture]
Source\WebKit\NetworkProcess/cache/NetworkCache.cpp(415,283): warning: lambda capture 'allowPrivacyProxy' is not used [-Wunused-lambda-capture]
Source\WebKit\NetworkProcess/cache/NetworkCache.cpp(415,302): warning: lambda capture 'advancedPrivacyProtections' is not used [-Wunused-lambda-capture]
Source\WebKit\Shared\win/WebEventFactory.h(51,126): warning: missing field 'time' initializer [-Wmissing-field-initializers]
Source\WebKit\UIProcess\Inspector\socket\RemoteInspectorClient.cpp(89,38): warning: 'configurationForRemoteInspector' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
Tools\MiniBrowser\win\MainWindow.cpp(128,15): warning: unused variable 'numButtons' [-Wunused-variable]
Tools\MiniBrowser\win\MainWindow.cpp(162,72): warning: missing field 'idCommand' initializer [-Wmissing-field-initializers]
Tools\MiniBrowser\win\MainWindow.cpp(181,72): warning: missing field 'idCommand' initializer [-Wmissing-field-initializers]
Tools\TestWebKitAPI\Tests\WTF\StdLibExtrasTests.cpp(127,9): warning: unused type alias '__thisIsHereToForceASemicolonAfterThisMacro' [-Wunused-local-typedef]
Tools\TestWebKitAPI\Tests\WebCore\FloatRectTests.cpp(572,13): warning: unused function 'checkCastRect' [-Wunused-function]
Tools\TestWebKitAPI\Tests\WebKit\ReloadPageAfterCrash.cpp(48,13): warning: unused variable 'calledCrashHandler' [-Wunused-variable]

* Source/WebKit/GPUProcess/graphics/wc/RemoteWCLayerTreeHost.cpp:
(WebKit::RemoteWCLayerTreeHost::update):
* Source/WebKit/NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::Cache::retrieve):
* Source/WebKit/NetworkProcess/curl/WebSocketTaskCurl.h:
* Source/WebKit/Shared/win/WebEventFactory.h:
(WebKit::createNativeEvent):
* Source/WebKit/UIProcess/Inspector/socket/RemoteInspectorClient.cpp:
* Tools/MiniBrowser/win/MainWindow.cpp:
(MainWindow::createToolbar):
(MainWindow::resizeToolbar):
(MainWindow::rescaleToolbar):
* Tools/TestWebKitAPI/Tests/WTF/StdLibExtrasTests.cpp:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WebCore/FloatRectTests.cpp:
* Tools/TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:

Canonical link: https://commits.webkit.org/266057@main