[webkit-changes] [WebKit/WebKit] 2dfe83: Special-casing the zero glyph page is unnecessary

Myles C. Maxfield noreply at github.com
Thu Jul 13 17:11:54 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2dfe83b6f5fd67ea089c2fe200ddabc72170eb90
      https://github.com/WebKit/WebKit/commit/2dfe83b6f5fd67ea089c2fe200ddabc72170eb90
  Author: Myles C. Maxfield <mmaxfield at apple.com>
  Date:   2023-07-13 (Thu, 13 Jul 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/FontCascadeFonts.cpp
    M Source/WebCore/platform/graphics/FontCascadeFonts.h

  Log Message:
  -----------
  Special-casing the zero glyph page is unnecessary
https://bugs.webkit.org/show_bug.cgi?id=259180
rdar://112186000

Reviewed by Simon Fraser.

Each glyph page only holds 16 characters, so the 0th glyph page isn't really special.
Almost no text will actually use it. So there's no need to special-case it. (I bet
that this special-case wasn't actually created for performance, but just because of
how our HashMaps treat 0 as empty...)

* Source/WebCore/platform/graphics/FontCascadeFonts.cpp:
(WebCore::FontCascadeFonts::glyphDataForCharacter):
(WebCore::FontCascadeFonts::pruneSystemFallbacks):
* Source/WebCore/platform/graphics/FontCascadeFonts.h:

Canonical link: https://commits.webkit.org/266052@main




More information about the webkit-changes mailing list