[webkit-changes] [WebKit/WebKit] ae256c: Stop using Number.prototype.toLocaleString() for n...

Devin Rousso noreply at github.com
Wed Jul 12 18:58:55 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ae256c9a88dbbca6c460fa52db025f531b7a4cf5
      https://github.com/WebKit/WebKit/commit/ae256c9a88dbbca6c460fa52db025f531b7a4cf5
  Author: Devin Rousso <hi at devinrousso.com>
  Date:   2023-07-12 (Wed, 12 Jul 2023)

  Changed paths:
    M Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js

  Log Message:
  -----------
  Stop using Number.prototype.toLocaleString() for numeric console format specifiers
https://bugs.webkit.org/show_bug.cgi?id=259146

Reviewed by Patrick Angle.

`console.log("%i", 1000)` should have the same output as `console.log("1000")`.

* Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js:
(WI.ConsoleMessageView.prototype._formatWithSubstitutionString.floatFormatter):
(WI.ConsoleMessageView.prototype._formatWithSubstitutionString.integerFormatter):
Remove calling `Number.prototype.toLocaleString` as that can insert unwanted text (e.g. commas).

Canonical link: https://commits.webkit.org/266020@main




More information about the webkit-changes mailing list