[webkit-changes] [WebKit/WebKit] 8afe94: Add invalid checks for static ranges

Jessica Cheung noreply at github.com
Wed Jul 12 17:55:01 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8afe94ae85ece85e0453b8cdf574b3c23b01c800
      https://github.com/WebKit/WebKit/commit/8afe94ae85ece85e0453b8cdf574b3c23b01c800
  Author: Jessica Cheung <jcheung23 at apple.com>
  Date:   2023-07-12 (Wed, 12 Jul 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    M Source/WebCore/dom/StaticRange.cpp
    M Source/WebCore/dom/StaticRange.h
    M Source/WebCore/rendering/MarkedText.cpp
    M Source/WebCore/rendering/StyledMarkedText.cpp

  Log Message:
  -----------
  Add invalid checks for static ranges
https://bugs.webkit.org/show_bug.cgi?id=258826
rdar://111706100

Reviewed by Ryosuke Niwa.

Added invalid checks for static range.
Thus, ignoring the invalid range when painting highlights.
Changed TestExpectations due to more tests passing.

* LayoutTests/TestExpectations:
* Source/WebCore/dom/StaticRange.cpp:
(WebCore::StaticRange::computeRangeValidity const):
(WebCore::StaticRange::isValidForPaintingHighlights const):
* Source/WebCore/dom/StaticRange.h:
* Source/WebCore/rendering/MarkedText.cpp:
(WebCore::MarkedText::collectForHighlights):
* Source/WebCore/rendering/StyledMarkedText.cpp:
(WebCore::coalesceAdjacentWithSameRanges):

Canonical link: https://commits.webkit.org/266019@main




More information about the webkit-changes mailing list