[webkit-changes] [WebKit/WebKit] 27b843: AX VoiceOver: some content on web pages is not dis...

AndresGonzalezApple noreply at github.com
Tue Jul 11 11:40:42 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 27b843503fcfe584951512ed99d4b10648998287
      https://github.com/WebKit/WebKit/commit/27b843503fcfe584951512ed99d4b10648998287
  Author: Andres Gonzalez <andresg_22 at apple.com>
  Date:   2023-07-11 (Tue, 11 Jul 2023)

  Changed paths:
    A LayoutTests/accessibility/mac/attributed-string-for-text-marker-range-using-webarea-expected.txt
    A LayoutTests/accessibility/mac/attributed-string-for-text-marker-range-using-webarea.html
    M Source/WebCore/accessibility/AXTextMarker.cpp
    M Source/WebCore/accessibility/AXTextMarker.h
    M Source/WebCore/accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm

  Log Message:
  -----------
  AX VoiceOver: some content on web pages is not displayed on the braille display.
https://bugs.webkit.org/show_bug.cgi?id=259066
rdar://110758833

Reviewed by Tyler Wilcock.

AX clients like VoiceOver may request the AttributedString of a TextMarkerRange using the WebArea object. Since we don't cache the AttributedString for the WebArea, this causes a hit to the main thread. Furthermore, since the TextMarkerRange for a given object is created off the main thread and expects to be accessed off the main thread, it may not return the correct AttributedString when used on the main thread. This change ensures that the cached AttributedString for a given object is returned even when it is requested using the WebArea or any other object instead the object that owns the range.

Canonical link: https://commits.webkit.org/265957@main




More information about the webkit-changes mailing list