[webkit-changes] [WebKit/WebKit] f438e8: Animation using padding-block doesnt override set ...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f438e854500a424cbcef992bcfec923d0b7d26b8
      https://github.com/WebKit/WebKit/commit/f438e854500a424cbcef992bcfec923d0b7d26b8
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2023-07-11 (Tue, 11 Jul 2023)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-logical/animations/padding-block-interpolation-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-logical/animations/padding-block-interpolation.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-logical/animations/padding-inline-interpolation-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-logical/animations/padding-inline-interpolation.html
    M Source/WebCore/animation/CSSPropertyAnimation.cpp
    M Source/WebCore/style/Styleable.cpp

  Log Message:
  -----------
  Animation using padding-block doesnt override set padding style
https://bugs.webkit.org/show_bug.cgi?id=258813
rdar://112023856

Reviewed by Tim Nguyen.

We did not support animating the padding-block shorthand. To do so we must do two things:

1. in CSSPropertyAnimation.cpp we must actually mark that shorthand as animatable.
2. in transitionMatchesProperty() we must support the possibility that a property
   is a shorthand for logical properties.

I suppose we could make transitionMatchesProperty() re-entrant in some way such that shorthands
of shorthands could also work, but this will do for now.

We also add animation support for padding-inline since it's a closely-related shorthand.

* LayoutTests/imported/w3c/web-platform-tests/css/css-logical/animations/padding-block-interpolation-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-logical/animations/padding-block-interpolation.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-logical/animations/padding-inline-interpolation-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-logical/animations/padding-inline-interpolation.html: Added.
* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* Source/WebCore/style/Styleable.cpp:
(WebCore::transitionMatchesProperty):

Canonical link: https://commits.webkit.org/265956@main