[webkit-changes] [WebKit/WebKit] 59f29a: [WPE] `TestWebKitWebView` `/webkit/WebKitWebView/f...
Vitaly Dyachkov
noreply at github.com
Thu Jul 6 06:07:33 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 59f29abe483ee8b33b50f5f476f88f67ef5836d8
https://github.com/WebKit/WebKit/commit/59f29abe483ee8b33b50f5f476f88f67ef5836d8
Author: Vitaly Dyachkov <vitaly at igalia.com>
Date: 2023-07-06 (Thu, 06 Jul 2023)
Changed paths:
M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp
M Source/WebKit/UIProcess/API/wpe/APIViewClient.h
M Source/WebKit/UIProcess/API/wpe/PageClientImpl.cpp
M Source/WebKit/UIProcess/API/wpe/WPEView.cpp
M Source/WebKit/UIProcess/API/wpe/WebKitWebViewClient.h
M Tools/TestWebKitAPI/glib/TestExpectations.json
Log Message:
-----------
[WPE] `TestWebKitWebView` `/webkit/WebKitWebView/fullscreen` is a timeout
https://bugs.webkit.org/show_bug.cgi?id=258850
Reviewed by Michael Catanzaro.
On WPE `WKWPE::View` creates a web page with its own page client.
But when using GLib API we must somehow notify the wrapper `WebKitWebView`
about entering and exiting fullscreen mode.
The solution is to extend `WKWPE::API::Client` with two new methods:
- `enterFullScreen()`
- `exitFullScreen()`
`WebKitWebViewClient`, which implements `WKWPE::API::Client` and has
a reference to `WebKitWebView` wrapper, can react on these events and
call appropriate handlers.
* Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:
(WebKitWebViewClient::enterFullScreen):
(WebKitWebViewClient::exitFullScreen):
* Source/WebKit/UIProcess/API/wpe/APIViewClient.h:
(API::ViewClient::enterFullScreen):
(API::ViewClient::exitFullScreen):
* Source/WebKit/UIProcess/API/wpe/PageClientImpl.cpp:
(WebKit::PageClientImpl::enterFullScreen):
(WebKit::PageClientImpl::exitFullScreen):
* Source/WebKit/UIProcess/API/wpe/WPEView.cpp:
(WKWPE::View::enterFullScreen):
(WKWPE::View::exitFullScreen):
* Source/WebKit/UIProcess/API/wpe/WPEView.h:
* Source/WebKit/UIProcess/API/wpe/WebKitWebViewClient.h:
* Tools/TestWebKitAPI/glib/TestExpectations.json:
Canonical link: https://commits.webkit.org/265799@main
More information about the webkit-changes
mailing list