[webkit-changes] [WebKit/WebKit] 920415: [browserperfdash-benchmark] Allow to send benchmar...

Carlos Alberto Lopez Perez noreply at github.com
Thu Jul 6 05:28:00 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9204150b17ce55af8037fac41b58fd0e0d458b26
      https://github.com/WebKit/WebKit/commit/9204150b17ce55af8037fac41b58fd0e0d458b26
  Author: Carlos Alberto Lopez Perez <clopez at igalia.com>
  Date:   2023-07-06 (Thu, 06 Jul 2023)

  Changed paths:
    M Tools/CISupport/build-webkit-org/steps.py
    M Tools/Scripts/webkitpy/browserperfdash/browserperfdash_runner.py

  Log Message:
  -----------
  [browserperfdash-benchmark] Allow to send benchmark data with the timestamp of the git checkout and use it on the bots
https://bugs.webkit.org/show_bug.cgi?id=258920

Reviewed by Carlos Garcia Campos.

Now that we are running several bots in parallel for the same worker
there is no guarantee that the bots will finish in the same order
than they started. So it can happen that we send the benchmark data
in different ordering than the commits on the repository.

To avoid this (and also allow re-testing old checkouts) this implements
a way of sending to the server dashboard as timestamp of the benchmark
the same timestamp of the git commit that is checked out (HEAD).

And since the bots always check-out the same git commit than the build
they are testing, we can use this there and run everything in parallel
safely.

* Tools/CISupport/build-webkit-org/steps.py:
(RunBenchmarkTests):
* Tools/Scripts/webkitpy/browserperfdash/browserperfdash_runner.py:
(parse_args):
(BrowserPerfDashRunner.__init__):

Canonical link: https://commits.webkit.org/265798@main




More information about the webkit-changes mailing list