[webkit-changes] [WebKit/WebKit] 20a4f6: Rename Internal Blob URL registration

Matthew Finkel noreply at github.com
Wed Jul 5 19:28:40 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 20a4f6d1b5da43bc85880e6a8af35132f3822020
      https://github.com/WebKit/WebKit/commit/20a4f6d1b5da43bc85880e6a8af35132f3822020
  Author: Matthew Finkel <sysrqb at apple.com>
  Date:   2023-07-05 (Wed, 05 Jul 2023)

  Changed paths:
    M Source/WebCore/fileapi/Blob.cpp
    M Source/WebCore/fileapi/File.cpp
    M Source/WebCore/fileapi/ThreadableBlobRegistry.cpp
    M Source/WebCore/fileapi/ThreadableBlobRegistry.h
    M Source/WebCore/platform/network/BlobRegistry.h
    M Source/WebCore/platform/network/BlobRegistryImpl.cpp
    M Source/WebCore/platform/network/BlobRegistryImpl.h
    M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
    M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
    M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in
    M Source/WebKit/NetworkProcess/NetworkProcessPlatformStrategies.cpp
    M Source/WebKit/WebProcess/FileAPI/BlobRegistryProxy.cpp
    M Source/WebKit/WebProcess/FileAPI/BlobRegistryProxy.h
    M Source/WebKitLegacy/mac/WebCoreSupport/WebPlatformStrategies.mm

  Log Message:
  -----------
  Rename Internal Blob URL registration
https://bugs.webkit.org/show_bug.cgi?id=258359
rdar://problem/111107487

Reviewed by Chris Dumez.

Some Blob registration functionality is only used for internal URLs. This
change makes clear that registering a Blob URL is restricted to internal URLs
and there isn't an associated top origin. There is one remaining registration
function that will accept an optional SecurityOriginData in a follow-up patch,
and that function is used for registering both public and internal blob URLs.

* Source/WebCore/fileapi/Blob.cpp:
(WebCore::Blob::Blob):
* Source/WebCore/fileapi/File.cpp:
(WebCore::File::create):
* Source/WebCore/fileapi/ThreadableBlobRegistry.cpp:
(WebCore::isInternalBlobURL):
(WebCore::ThreadableBlobRegistry::registerInternalFileBlobURL):
(WebCore::ThreadableBlobRegistry::registerInternalBlobURL):
(WebCore::ThreadableBlobRegistry::registerInternalBlobURLOptionallyFileBacked):
(WebCore::ThreadableBlobRegistry::registerInternalBlobURLForSlice):
(WebCore::ThreadableBlobRegistry::registerFileBlobURL): Deleted.
(WebCore::ThreadableBlobRegistry::registerBlobURLOptionallyFileBacked): Deleted.
(WebCore::ThreadableBlobRegistry::registerBlobURLForSlice): Deleted.
* Source/WebCore/fileapi/ThreadableBlobRegistry.h:
* Source/WebCore/platform/network/BlobRegistry.h:
* Source/WebCore/platform/network/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::registerInternalFileBlobURL):
(WebCore::BlobRegistryImpl::registerInternalBlobURL):
(WebCore::BlobRegistryImpl::registerInternalBlobURLOptionallyFileBacked):
(WebCore::BlobRegistryImpl::registerInternalBlobURLForSlice):
(WebCore::BlobRegistryImpl::registerFileBlobURL): Deleted.
(WebCore::BlobRegistryImpl::registerBlobURLForSlice): Deleted.
* Source/WebCore/platform/network/BlobRegistryImpl.h:
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::registerInternalFileBlobURL):
(WebKit::NetworkConnectionToWebProcess::registerInternalBlobURL):
(WebKit::NetworkConnectionToWebProcess::registerBlobURL):
(WebKit::NetworkConnectionToWebProcess::registerInternalBlobURLOptionallyFileBacked):
(WebKit::NetworkConnectionToWebProcess::registerInternalBlobURLForSlice):
(WebKit::NetworkConnectionToWebProcess::registerFileBlobURL): Deleted.
(WebKit::NetworkConnectionToWebProcess::registerBlobURLFromURL): Deleted.
(WebKit::NetworkConnectionToWebProcess::registerBlobURLOptionallyFileBacked): Deleted.
(WebKit::NetworkConnectionToWebProcess::registerBlobURLForSlice): Deleted.
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h:
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* Source/WebKit/NetworkProcess/NetworkProcessPlatformStrategies.cpp:
(WebKit::NetworkProcessPlatformStrategies::createBlobRegistry):
* Source/WebKit/WebProcess/FileAPI/BlobRegistryProxy.cpp:
(WebKit::BlobRegistryProxy::registerInternalFileBlobURL):
(WebKit::BlobRegistryProxy::registerInternalBlobURL):
(WebKit::BlobRegistryProxy::registerBlobURL):
(WebKit::BlobRegistryProxy::registerInternalBlobURLOptionallyFileBacked):
(WebKit::BlobRegistryProxy::registerInternalBlobURLForSlice):
(WebKit::BlobRegistryProxy::registerFileBlobURL): Deleted.
(WebKit::BlobRegistryProxy::registerBlobURLOptionallyFileBacked): Deleted.
(WebKit::BlobRegistryProxy::registerBlobURLForSlice): Deleted.
* Source/WebKit/WebProcess/FileAPI/BlobRegistryProxy.h:
* Source/WebKitLegacy/mac/WebCoreSupport/WebPlatformStrategies.mm:

Canonical link: https://commits.webkit.org/265789@main




More information about the webkit-changes mailing list