[webkit-changes] [WebKit/WebKit] 0e157e: Make topOrigin optional in URLKeepingBlobAlive

Matthew Finkel noreply at github.com
Wed Jul 5 19:27:10 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0e157e8e441ff79d3915536606872dd9054b559f
      https://github.com/WebKit/WebKit/commit/0e157e8e441ff79d3915536606872dd9054b559f
  Author: Matthew Finkel <sysrqb at apple.com>
  Date:   2023-07-05 (Wed, 05 Jul 2023)

  Changed paths:
    M Source/WebCore/fileapi/Blob.cpp
    M Source/WebCore/fileapi/URLKeepingBlobAlive.cpp
    M Source/WebCore/fileapi/URLKeepingBlobAlive.h
    M Source/WebCore/page/SecurityOriginData.h

  Log Message:
  -----------
  Make topOrigin optional in URLKeepingBlobAlive
https://bugs.webkit.org/show_bug.cgi?id=256499
rdar://problem/109067113

Reviewed by Chris Dumez.

The top origin SecurityOriginData is not always required for keeping a Blob
alive. In the case where the Blob URL is the Blob's internal URL, there is not
an associated top origin. Therefore, we only set the top origin for Blob URLs
that are created by script where the top origin is well defined.

* Source/WebCore/fileapi/Blob.cpp:
(WebCore::Blob::handle const):
* Source/WebCore/fileapi/URLKeepingBlobAlive.cpp:
(WebCore::URLKeepingBlobAlive::URLKeepingBlobAlive):
(WebCore::URLKeepingBlobAlive::clear):
(WebCore::URLKeepingBlobAlive::isolatedCopy const):
* Source/WebCore/fileapi/URLKeepingBlobAlive.h:
(WebCore::URLKeepingBlobAlive::topOrigin const):
* Source/WebCore/page/SecurityOriginData.h:
(WebCore::SecurityOriginDataMarkableTraits::isEmptyValue):
(WebCore::SecurityOriginDataMarkableTraits::emptyValue):

Canonical link: https://commits.webkit.org/265788@main




More information about the webkit-changes mailing list