[webkit-changes] [WebKit/WebKit] 44564f: [WPE][GTK] API test `TestWebKitUserContentManager`...

Vitaly Dyachkov noreply at github.com
Mon Jul 3 06:30:36 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 44564f381a286bca91da3fea7f3de0ddcaae8517
      https://github.com/WebKit/WebKit/commit/44564f381a286bca91da3fea7f3de0ddcaae8517
  Author: Vitaly Dyachkov <vitaly at igalia.com>
  Date:   2023-07-03 (Mon, 03 Jul 2023)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp
    M Tools/TestWebKitAPI/glib/TestExpectations.json

  Log Message:
  -----------
  [WPE][GTK] API test `TestWebKitUserContentManager` `/webkit/WebKitUserContentManager/script-message-received` is a timeout
https://bugs.webkit.org/show_bug.cgi?id=258797

Reviewed by Carlos Garcia Campos.

Since we use one instance of `UserScriptMessageTest` for all tests in
`TestWebKitUserContentManager.cpp`, we must clear the previously
received `m_scriptMessage` every time we `postMessageAndWaitUntilReceived()`.

We'll get a failed assertion in `scriptMessageReceived()` if we don't:

```
g_assert_null(test->m_script Message.get());
```

This regression was introduced in 261320 at main.

* Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
(UserScriptMessageTest::waitUntilMessageReceived):
* Tools/TestWebKitAPI/glib/TestExpectations.json:

Canonical link: https://commits.webkit.org/265716@main




More information about the webkit-changes mailing list