[webkit-changes] [WebKit/WebKit] de84aa: Generated IPC serializers use deprecated stream in...

Kimmo Kinnunen noreply at github.com
Mon Jul 3 05:18:00 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: de84aa87132c9e7825fae9f797ce581bf58df292
      https://github.com/WebKit/WebKit/commit/de84aa87132c9e7825fae9f797ce581bf58df292
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2023-07-03 (Mon, 03 Jul 2023)

  Changed paths:
    M Source/WebKit/Scripts/generate-serializers.py
    M Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.cpp

  Log Message:
  -----------
  Generated IPC serializers use deprecated stream input operator
https://bugs.webkit.org/show_bug.cgi?id=258605
rdar://problem/111435260

Reviewed by Alex Christensen.

Remove the >> use from the generated serializers so that the precedent
is removed, which might make it simpler to remove operator>>
implementation in the future.

Pattern is deprecated:
    std::optional<T> result;
    decoder >> result;

This is on the grounds of it requring default-constructible T.

For all types, we have to have support for:
    auto result = decoder.decode<T>();

Since we need latter anyway, we having the former is redundant.

* Source/WebKit/Scripts/generate-serializers.py:
(decode_type):
* Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.cpp:
(IPC::ArgumentCoder<WebCore::TimingFunction>::decode):
(IPC::ArgumentCoder<WebCore::MoveOnlyBaseClass>::decode):

Canonical link: https://commits.webkit.org/265715@main




More information about the webkit-changes mailing list