[webkit-changes] [WebKit/WebKit] 41c888: New broken test: http/wpt/service-workers/fetch-se...

youennf noreply at github.com
Mon Jul 3 00:26:19 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 41c888f493fe21f4a759e4dee01532181f629833
      https://github.com/WebKit/WebKit/commit/41c888f493fe21f4a759e4dee01532181f629833
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2023-07-03 (Mon, 03 Jul 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/http/wpt/service-workers/fetch-service-worker-preload-changing-request.https-expected.txt
    M LayoutTests/http/wpt/service-workers/fetch-service-worker-preload-changing-request.https.html
    M Source/WebCore/Modules/fetch/FetchRequest.cpp

  Log Message:
  -----------
  New broken test: http/wpt/service-workers/fetch-service-worker-preload-changing-request.https.html fails
https://bugs.webkit.org/show_bug.cgi?id=248735
rdar://problem/103220705

Reviewed by Alex Christensen.

When calling fetch(event.request), we are creating a new FetchRequest.
To be able to reuse the preload, we need to set the navigation preload identifier in the new FetchRequest.
We make sure to not set it when the request is changed, in particular its headers.

Covered by tests no longer failing.
CoveWe update LayoutTests/http/wpt/service-workers/fetch-service-worker-preload-changing-request.https.html since it must not reuse preload in that case.
Cove
Cove* LayoutTests/TestExpectations:
Cove* LayoutTests/http/wpt/service-workers/fetch-service-worker-preload-changing-request.https-expected.txt:
* LayoutTests/http/wpt/service-workers/fetch-service-worker-preload-changing-request.https.html:
* Source/WebCore/Modules/fetch/FetchRequest.cpp:
(WebCore::FetchRequest::initializeWith):

Canonical link: https://commits.webkit.org/265705@main




More information about the webkit-changes mailing list