[webkit-changes] [WebKit/WebKit] d15613: Small cleanup on BMPImageReader.cpp

Ahmad Saleem noreply at github.com
Mon Jul 3 00:10:04 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d156132fce2fe3a0d90b92c2866ca4776c473316
      https://github.com/WebKit/WebKit/commit/d156132fce2fe3a0d90b92c2866ca4776c473316
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-07-03 (Mon, 03 Jul 2023)

  Changed paths:
    M Source/WebCore/platform/image-decoders/bmp/BMPImageReader.cpp
    M Source/WebCore/platform/image-decoders/bmp/BMPImageReader.h

  Log Message:
  -----------
  Small cleanup on BMPImageReader.cpp

https://bugs.webkit.org/show_bug.cgi?id=253123
rdar://problem/106387835

Reviewed by Fujii Hironori.

Merge: https://chromium.googlesource.com/chromium/blink/+/a057769943417c61acd574458034ac6546ed6f6a

'm_headerOffset + m_infoHeader.biSize' is used often in BMPImageReader.cpp.
It is even recalulated several time in a same function. This patch cleans up
this kind of repeated code.

* Source/WebCore/platform/image-decoders/bmp/BMPImageReader.cpp:
(BMPImageReader::BMPImageReader):
(BMPImageReader::decodeBMP):
(BMPImageReader::readInfoHeaderSize):
(BMPImageReader::processBitmasks):
(BMPImageReader::processColorTable):
* Source/WebCore/platform/image-decoders/bmp/BMPImageReader.h: Remove 'm_tableSizeInBytes'

Canonical link: https://commits.webkit.org/265704@main




More information about the webkit-changes mailing list