[webkit-changes] [WebKit/WebKit] 2b4d43: [UI-side compositing] Hide native scrollbars for l...

[Nikos Mouchtaris]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2b4d439acd797ee4cd48aac0d57780c5c8d16985
      https://github.com/WebKit/WebKit/commit/2b4d439acd797ee4cd48aac0d57780c5c8d16985
  Author: Nikolaos Mouchtaris <nmouchtaris at apple.com>
  Date:   2023-01-26 (Thu, 26 Jan 2023)

  Changed paths:
    M Source/WebCore/page/scrolling/ScrollingTreeScrollingNodeDelegate.h
    M Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.h
    M Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm
    M Source/WebCore/platform/Scrollbar.cpp
    M Source/WebKit/UIProcess/RemoteLayerTree/mac/ScrollingTreeFrameScrollingNodeRemoteMac.cpp
    M Source/WebKit/UIProcess/RemoteLayerTree/mac/ScrollingTreeOverflowScrollingNodeRemoteMac.cpp

  Log Message:
  -----------
  [UI-side compositing] Hide native scrollbars for layout tests
https://bugs.webkit.org/show_bug.cgi?id=251235
rdar://104720292

Reviewed by Simon Fraser.

Since layout tests use mock scrollbars, we also need to hide native scrollbars for this case.
To do so we check DeprecatedGlobalSettings::mockScrollbarsEnabled in
Scrollbar::nativeScrollbarVisibility. We also refactor some of the code that handles turning off
the native scrollbars to use the getters on ScrollingTreeScrollingNode.

* Source/WebCore/page/scrolling/ScrollingTreeScrollingNodeDelegate.h:
(WebCore::ScrollingTreeScrollingNodeDelegate::getScrollbarLayersForStateNode): Deleted.
* Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.h:
* Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm:
(WebCore::ScrollingTreeScrollingNodeDelegateMac::getScrollbarLayersForStateNode): Deleted.
* Source/WebCore/platform/Scrollbar.cpp:
(WebCore::Scrollbar::nativeScrollbarVisibility):
* Source/WebKit/UIProcess/RemoteLayerTree/mac/ScrollingTreeFrameScrollingNodeRemoteMac.cpp:
(WebKit::ScrollingTreeFrameScrollingNodeRemoteMac::commitStateBeforeChildren):
* Source/WebKit/UIProcess/RemoteLayerTree/mac/ScrollingTreeOverflowScrollingNodeRemoteMac.cpp:
(WebKit::ScrollingTreeOverflowScrollingNodeRemoteMac::commitStateBeforeChildren):

Canonical link: https://commits.webkit.org/259467@main