[webkit-changes] [WebKit/WebKit] 472954: The Clear-Site-Data HTTP header should obey origin...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 472954140c3524db1deebdf2a895d376548ebb52
      https://github.com/WebKit/WebKit/commit/472954140c3524db1deebdf2a895d376548ebb52
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-01-26 (Thu, 26 Jan 2023)

  Changed paths:
    A LayoutTests/http/wpt/clear-site-data/partitioning-expected.txt
    A LayoutTests/http/wpt/clear-site-data/partitioning.html
    A LayoutTests/http/wpt/clear-site-data/resources/partitioning-popup.html
    M LayoutTests/platform/glib/TestExpectations
    M Source/WebCore/loader/cache/MemoryCache.cpp
    M Source/WebCore/loader/cache/MemoryCache.h
    M Source/WebCore/platform/network/NetworkStorageSession.cpp
    M Source/WebCore/platform/network/NetworkStorageSession.h
    M Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm
    M Source/WebCore/workers/service/server/SWServer.cpp
    M Source/WebCore/workers/service/server/SWServer.h
    M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
    M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
    M Source/WebKit/NetworkProcess/NetworkProcess.cpp
    M Source/WebKit/NetworkProcess/NetworkProcess.h
    M Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
    M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp
    M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.h
    M Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
    M Source/WebKit/UIProcess/Network/NetworkProcessProxy.h
    M Source/WebKit/UIProcess/Network/NetworkProcessProxy.messages.in
    M Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp
    M Source/WebKit/WebProcess/Network/NetworkProcessConnection.h
    M Source/WebKit/WebProcess/Network/NetworkProcessConnection.messages.in
    M Source/WebKit/WebProcess/WebProcess.cpp
    M Source/WebKit/WebProcess/WebProcess.h
    M Source/WebKit/WebProcess/WebProcess.messages.in

  Log Message:
  -----------
  The Clear-Site-Data HTTP header should obey origin partition
https://bugs.webkit.org/show_bug.cgi?id=251094

Reviewed by Youenn Fablet.

The Clear-Site-Data HTTP header should obey origin partition. If shouldn't be
possible for an iframe of origin A under top origin B to be able to clear site
data from top origin A (and vice-versa).

Our storages are partitioned and the request to clear site data should respect
that.

* LayoutTests/http/wpt/clear-site-data/partitioning-expected.txt: Added.
* LayoutTests/http/wpt/clear-site-data/partitioning.html: Added.
* LayoutTests/http/wpt/clear-site-data/resources/partitioning-popup.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/clear-site-data/support/test_utils.sub.js:
* Source/WebCore/loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::removeResourcesWithOrigin):
* Source/WebCore/loader/cache/MemoryCache.h:
* Source/WebCore/platform/network/NetworkStorageSession.cpp:
(WebCore::NetworkStorageSession::deleteCookies):
* Source/WebCore/platform/network/NetworkStorageSession.h:
* Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm:
(WebCore::NetworkStorageSession::deleteCookiesMatching):
(WebCore::NetworkStorageSession::deleteCookies):
(WebCore::NetworkStorageSession::deleteCookiesForHostnames):
* Source/WebCore/workers/service/ServiceWorkerRegistrationKey.cpp:
(WebCore::ServiceWorkerRegistrationKey::matchesOriginWithCachePartition const):
* Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h:
* Source/WebCore/workers/service/server/SWServer.cpp:
(WebCore::SWServer::clear):
(WebCore::SWServer::clearInternal):
* Source/WebCore/workers/service/server/SWServer.h:
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::deleteWebsiteDataForOrigin):
(WebKit::NetworkConnectionToWebProcess::deleteWebsiteDataForOrigins): Deleted.
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h:
* Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::deleteWebsiteDataForOrigin):
* Source/WebKit/NetworkProcess/NetworkProcess.h:
* Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::processClearSiteDataHeader):
* Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp:
(WebKit::NetworkStorageManager::deleteData):
* Source/WebKit/NetworkProcess/storage/NetworkStorageManager.h:
* Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::deleteWebsiteDataForOrigin):
(WebKit::NetworkProcessConnection::deleteWebsiteDataForOrigins): Deleted.
* Source/WebKit/WebProcess/Network/NetworkProcessConnection.h:
* Source/WebKit/WebProcess/Network/NetworkProcessConnection.messages.in:
* Source/WebKit/WebProcess/WebProcess.cpp:
(WebKit::WebProcess::deleteWebsiteDataForOrigin):
* Source/WebKit/WebProcess/WebProcess.h:

Canonical link: https://commits.webkit.org/259466@main