[webkit-changes] [WebKit/WebKit] d5823d: Fix tests that use `eventSender.mouseScrollBy()` t...

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d5823dca0a47f5a8bf31732ca7c74b4dd9b6a991
      https://github.com/WebKit/WebKit/commit/d5823dca0a47f5a8bf31732ca7c74b4dd9b6a991
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2023-01-24 (Tue, 24 Jan 2023)

  Changed paths:
    M LayoutTests/fast/events/platform-wheelevent-with-delta-zero-crash.html
    M LayoutTests/fast/events/remove-child-onscroll.html
    M LayoutTests/fast/events/scroll-in-scaled-page-with-overflow-hidden.html
    M LayoutTests/fast/events/wheel/platform-wheelevent-in-scrolling-div.html
    M LayoutTests/fast/events/wheel/wheel-event-outside-body.html
    M LayoutTests/fast/events/wheel/wheelevent-basic.html
    M LayoutTests/fast/events/wheel/wheelevent-in-text-node.html
    M LayoutTests/fast/events/wheel/wheelevent-mousewheel-interaction.html
    M LayoutTests/fast/forms/search/search-scroll-hidden-decoration-container-crash.html
    M LayoutTests/fast/repaint/overflow-auto-in-overflow-auto-scrolled.html
    M LayoutTests/fast/scrolling/mac/horizontal-overflow-trapping-small-deltas.html
    M LayoutTests/fast/scrolling/mac/rubberband-overflow-in-wheel-region-root-jiggle.html
    M LayoutTests/fast/scrolling/mac/vertical-scroll-in-horizontal-scroller.html
    M LayoutTests/fast/scrolling/rtl-scrollbars-listbox-scroll.html
    M LayoutTests/fast/scrolling/scrolling-inside-scrolled-overflowarea.html
    M LayoutTests/platform/gtk/TestExpectations
    M LayoutTests/resources/ui-helper.js
    M LayoutTests/scrollbars/scroll-rtl-or-bt-layer.html

  Log Message:
  -----------
  Fix tests that use `eventSender.mouseScrollBy()` to use UIHelper.statelessMouseWheelScrollAt
https://bugs.webkit.org/show_bug.cgi?id=250355
rdar://104058894

Reviewed by Ryosuke Niwa.

Replace calls to `eventSender.mouseMoveTo(); eventSender.mouseScrollBy()` with a
call to `UIHelper.statelessMouseWheelScrollAt()`, making things async where necessary.

Add `UIHelper.waitForEventHandler()`, which wraps the given function in an event
handler and waits for it to fire.

* LayoutTests/fast/events/platform-wheelevent-with-delta-zero-crash.html:
* LayoutTests/fast/events/remove-child-onscroll.html:
* LayoutTests/fast/events/scroll-in-scaled-page-with-overflow-hidden.html:
* LayoutTests/fast/events/wheel/platform-wheelevent-in-scrolling-div.html:
* LayoutTests/fast/events/wheel/wheel-event-outside-body.html:
* LayoutTests/fast/events/wheel/wheelevent-basic.html:
* LayoutTests/fast/events/wheel/wheelevent-in-text-node.html:
* LayoutTests/fast/events/wheel/wheelevent-mousewheel-interaction.html:
* LayoutTests/fast/forms/search/search-scroll-hidden-decoration-container-crash.html:
* LayoutTests/fast/repaint/overflow-auto-in-overflow-auto-scrolled.html:
* LayoutTests/fast/scrolling/mac/horizontal-overflow-trapping-small-deltas.html:
* LayoutTests/fast/scrolling/mac/rubberband-overflow-in-wheel-region-root-jiggle.html:
* LayoutTests/fast/scrolling/mac/vertical-scroll-in-horizontal-scroller.html:
* LayoutTests/fast/scrolling/rtl-scrollbars-listbox-scroll.html:
* LayoutTests/fast/scrolling/scrolling-inside-scrolled-overflowarea.html:
* LayoutTests/resources/ui-helper.js:
(window.UIHelper.async statelessMouseWheelScrollAt):
(window.UIHelper.waitForEventHandler):
(window.UIHelper.callFunctionAndWaitForEvent):
* LayoutTests/scrollbars/scroll-rtl-or-bt-layer.html:

Canonical link: https://commits.webkit.org/259295@main