[webkit-changes] [WebKit/WebKit] d85dae: Cherry-pick 252432.816 at safari-7614-branch (fa17c46...
Ryosuke Niwa
noreply at github.com
Tue Jan 24 11:04:54 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d85daec3645fee77f09a0f3e59928f1e1b9aa287
https://github.com/WebKit/WebKit/commit/d85daec3645fee77f09a0f3e59928f1e1b9aa287
Author: Ryosuke Niwa <rniwa at webkit.org>
Date: 2023-01-24 (Tue, 24 Jan 2023)
Changed paths:
A LayoutTests/editing/selection/modify-extend-iframe-orphan-expected.txt
A LayoutTests/editing/selection/modify-extend-iframe-orphan.html
M Source/WebCore/editing/FrameSelection.cpp
Log Message:
-----------
Cherry-pick 252432.816 at safari-7614-branch (fa17c4664715). rdar://104600217
ASSERTION FAILED: !document().selection().selection().isOrphan() in ContainerNode::removeNodeWithScriptAssertion
https://bugs.webkit.org/show_bug.cgi?id=247781
rdar://101497964
Reviewed by Wenson Hsieh, Darin Adler and Geoffrey Garen.
The bug was caused by VisibleSelection::setBase setting selection ends to point to nodes
in a wrong document as a side effect of calling VisibleSelection::validate when m_anchor
isn't cleared due to a node removal when live range selection is disabled.
* LayoutTests/editing/selection/modify-extend-iframe-orphan-expected.txt: Added.
* LayoutTests/editing/selection/modify-extend-iframe-orphan.html: Added.
* Source/WebCore/editing/FrameSelection.cpp:
(WebCore::selectionIsOrphanedOrBelongsToWrongDocument):
(WebCore::FrameSelection::willBeModified):
Canonical link: https://commits.webkit.org/252432.816@safari-7614-branch
Canonical link: https://commits.webkit.org/259294@main
More information about the webkit-changes
mailing list