[webkit-changes] [WebKit/WebKit] e3ebba: [GTK] Remove WebKitPrintCustomWidget from modern API

Michael Catanzaro noreply at github.com
Tue Jan 24 09:31:17 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e3ebba80adf1cc861a986732fe154aa72731b2b1
      https://github.com/WebKit/WebKit/commit/e3ebba80adf1cc861a986732fe154aa72731b2b1
  Author: Michael Catanzaro <mcatanzaro at redhat.com>
  Date:   2023-01-24 (Tue, 24 Jan 2023)

  Changed paths:
    M Source/WebKit/PlatformGTK.cmake
    M Source/WebKit/PlatformGTKDeprecated.cmake
    M Source/WebKit/SourcesGTK.txt
    M Source/WebKit/SourcesGTKDeprecated.txt
    M Source/WebKit/UIProcess/API/glib/WebKitAutocleanups.h.in
    M Source/WebKit/UIProcess/API/gtk/WebKitPrintCustomWidget.cpp
    M Source/WebKit/UIProcess/API/gtk/WebKitPrintCustomWidget.h.in
    M Source/WebKit/UIProcess/API/gtk/WebKitPrintOperation.cpp
    M Tools/TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp

  Log Message:
  -----------
  [GTK] Remove WebKitPrintCustomWidget from modern API
https://bugs.webkit.org/show_bug.cgi?id=244513

Reviewed by Carlos Garcia Campos.

Attaching custom widgets to the print dialog just cannot work when the
print dialog is out of process, and we really need to move to an out of
process dialog to fix printing in Flatpak.

Now, it would be possible to keep this functionality for non-flatpak
apps and leave it broken in Flatpak, but I'd much rather reduce user
experience divergence.

* Source/WebKit/PlatformGTK.cmake:
* Source/WebKit/PlatformGTKDeprecated.cmake:
* Source/WebKit/SourcesGTK.txt:
* Source/WebKit/SourcesGTKDeprecated.txt:
* Source/WebKit/UIProcess/API/glib/WebKitAutocleanups.h.in:
* Source/WebKit/UIProcess/API/gtk/WebKitPrintCustomWidget.cpp:
(webkit_print_custom_widget_class_init):
* Source/WebKit/UIProcess/API/gtk/WebKitPrintCustomWidget.h.in:
* Source/WebKit/UIProcess/API/gtk/WebKitPrintOperation.cpp:
(webkit_print_operation_class_init):
(webkitPrintOperationRunDialog):
* Tools/TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
(beforeAll):

Canonical link: https://commits.webkit.org/259286@main




More information about the webkit-changes mailing list