[webkit-changes] [WebKit/WebKit] f2357a: [WPE][GTK] Remove most webkit_web_view_new_with_*(...

Michael Catanzaro noreply at github.com
Tue Jan 24 09:08:46 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f2357aa3082326a6bad6e0d5a0198c159b5617bc
      https://github.com/WebKit/WebKit/commit/f2357aa3082326a6bad6e0d5a0198c159b5617bc
  Author: Michael Catanzaro <mcatanzaro at redhat.com>
  Date:   2023-01-24 (Tue, 24 Jan 2023)

  Changed paths:
    M Source/WebKit/UIProcess/API/glib/WebKitUserContentManager.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitWebView.h.in
    M Source/WebKit/UIProcess/API/gtk/WebKitWebViewGtk.cpp
    M Source/WebKit/UIProcess/API/wpe/WebKitWebViewWPE.cpp
    M Source/WebKit/gtk/migrating-to-webkitgtk-6.0.md
    M Tools/TestWebKitAPI/glib/WebKitGLib/TestMain.h

  Log Message:
  -----------
  [WPE][GTK] Remove most webkit_web_view_new_with_*() constructors
https://bugs.webkit.org/show_bug.cgi?id=250835

Reviewed by Carlos Garcia Campos.

So many constructors is unwieldy, and they're only useful if you need to
create a WebKitWebView with exactly one of the many construct
properties, which is a pretty niche situation. So get rid of them. An
exception is webkit_web_view_new_with_related_view() because it inherits
the relevant properties from the related view.

* Source/WebKit/UIProcess/API/glib/WebKitUserContentManager.cpp:
* Source/WebKit/UIProcess/API/glib/WebKitWebView.h.in:
* Source/WebKit/UIProcess/API/gtk/WebKitWebViewGtk.cpp:
* Source/WebKit/UIProcess/API/wpe/WebKitWebViewWPE.cpp:
* Source/WebKit/gtk/migrating-to-webkitgtk-6.0.md:
* Tools/TestWebKitAPI/glib/WebKitGLib/TestMain.h:
(Test::createWebView):

Canonical link: https://commits.webkit.org/259285@main




More information about the webkit-changes mailing list