[webkit-changes] [WebKit/WebKit] 90bd38: Parser's PropertyNode should never be given an Ide...

Commit Queue noreply at github.com
Sun Jan 22 08:45:29 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 90bd38013bce95b34bb0e4aa9f9501bc183a782f
      https://github.com/WebKit/WebKit/commit/90bd38013bce95b34bb0e4aa9f9501bc183a782f
  Author: Mark Lam <mark.lam at apple.com>
  Date:   2023-01-22 (Sun, 22 Jan 2023)

  Changed paths:
    A JSTests/stress/parser-property-node-identifier-should-not-be-null.js
    M Source/JavaScriptCore/builtins/BuiltinNames.h
    M Source/JavaScriptCore/parser/NodeConstructors.h
    M Source/JavaScriptCore/parser/Parser.cpp

  Log Message:
  -----------
  Parser's PropertyNode should never be given an Identifier with a null impl.
https://bugs.webkit.org/show_bug.cgi?id=250931
<rdar://problem/104507750>

Reviewed by Yusuke Suzuki.

For static initializer blocks, instead of passing a null Identifier, we'll use an Identifier
made from the newly introduced staticInitializerBlockPrivateName().

* JSTests/stress/parser-property-node-identifier-should-not-be-null.js: Added.
(Class.get c):
(Class):
* Source/JavaScriptCore/builtins/BuiltinNames.h:
* Source/JavaScriptCore/parser/NodeConstructors.h:
(JSC::PropertyNode::PropertyNode):
* Source/JavaScriptCore/parser/Parser.cpp:
(JSC::Parser<LexerType>::parseClass):

Canonical link: https://commits.webkit.org/259187@main




More information about the webkit-changes mailing list