[webkit-changes] [WebKit/WebKit] 2ec48f: Hook up UIScriptController::doAfterPresentationUpd...

Simon Fraser noreply at github.com
Sun Jan 22 08:42:13 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2ec48fe738ac98daee2aedddb73044f6329d6f9c
      https://github.com/WebKit/WebKit/commit/2ec48fe738ac98daee2aedddb73044f6329d6f9c
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2023-01-22 (Sun, 22 Jan 2023)

  Changed paths:
    M Tools/TestRunnerShared/UIScriptContext/UIScriptController.h
    M Tools/WebKitTestRunner/cocoa/UIScriptControllerCocoa.h
    M Tools/WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm
    M Tools/WebKitTestRunner/ios/UIScriptControllerIOS.h
    M Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm

  Log Message:
  -----------
  Hook up UIScriptController::doAfterPresentationUpdate for macOS
https://bugs.webkit.org/show_bug.cgi?id=250948
rdar://104516640

Reviewed by Myles C. Maxfield.

Share the implementation of `doAfterPresentationUpdate()` between macOS and iOS.

Have `doAfterNextStablePresentationUpdate()` call `doAfterPresentationUpdate()`,
since on most platforms there isn't a distinction between a "stable" and "unstable"
presentation update (on iOS, "unstable" refers to an update that happens when in a
transient state like rubber-banding).

* Tools/TestRunnerShared/UIScriptContext/UIScriptController.h:
(WTR::UIScriptController::doAfterNextStablePresentationUpdate):
* Tools/WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
* Tools/WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
(WTR::UIScriptControllerCocoa::doAfterPresentationUpdate):
* Tools/WebKitTestRunner/ios/UIScriptControllerIOS.h:
* Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptControllerIOS::doAfterPresentationUpdate): Deleted.

Canonical link: https://commits.webkit.org/259186@main




More information about the webkit-changes mailing list