[webkit-changes] [WebKit/WebKit] ac34f5: Fix handling of bidirectional override
Alan Baradlay
noreply at github.com
Sat Jan 21 12:50:08 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ac34f5d6508f974e2d4a61a24ce23fc2456bf71c
https://github.com/WebKit/WebKit/commit/ac34f5d6508f974e2d4a61a24ce23fc2456bf71c
Author: Alan Baradlay <zalan at apple.com>
Date: 2023-01-21 (Sat, 21 Jan 2023)
Changed paths:
A LayoutTests/fast/text/international/bdo-bidi-width-expected.html
A LayoutTests/fast/text/international/bdo-bidi-width.html
M LayoutTests/platform/ios/fast/css/vertical-text-overflow-ellipsis-text-align-center-mixed-expected.txt
M LayoutTests/platform/ios/fast/css/vertical-text-overflow-ellipsis-text-align-justify-mixed-expected.txt
M LayoutTests/platform/ios/fast/css/vertical-text-overflow-ellipsis-text-align-left-mixed-expected.txt
M LayoutTests/platform/ios/fast/css/vertical-text-overflow-ellipsis-text-align-right-mixed-expected.txt
M LayoutTests/platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-center-mixed-expected.txt
M LayoutTests/platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-justify-mixed-expected.txt
M LayoutTests/platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-left-mixed-expected.txt
M LayoutTests/platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-right-mixed-expected.txt
M LayoutTests/platform/mac/fast/text/atsui-rtl-override-selection-expected.txt
M LayoutTests/platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.txt
M LayoutTests/platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.txt
M Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp
Log Message:
-----------
Fix handling of bidirectional override
https://bugs.webkit.org/show_bug.cgi?id=250639
Reviewed by Antti Koivisto.
Let's setup TextRun with the correct direction/directional override values.
(It helps FontCascade to figure out the proper glyph set and return correct content width.)
* LayoutTests/fast/text/international/bdo-bidi-width-expected.html: Credits goes to eae at chromium.org (see https://chromium.googlesource.com/chromium/blink/+/fe79ee4457111490064d8bf9b6c5dce97f26b5d4)
* LayoutTests/fast/text/international/bdo-bidi-width.html: Added.
* Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp:
(WebCore::Layout::TextUtil::width):
Canonical link: https://commits.webkit.org/259172@main
More information about the webkit-changes
mailing list