[webkit-changes] [WebKit/WebKit] c934d4: Rename hasTransform() to isTransformed() on Render...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c934d4911662a8068e232e316860641e7ccbe020
      https://github.com/WebKit/WebKit/commit/c934d4911662a8068e232e316860641e7ccbe020
  Author: Antoine Quint <graouts at apple.com>
  Date:   2023-01-21 (Sat, 21 Jan 2023)

  Changed paths:
    M Source/WebCore/display/css/DisplayBox.h
    M Source/WebCore/rendering/BackgroundPainter.cpp
    M Source/WebCore/rendering/RenderBlock.cpp
    M Source/WebCore/rendering/RenderBlockFlow.cpp
    M Source/WebCore/rendering/RenderBox.cpp
    M Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp
    M Source/WebCore/rendering/RenderFlexibleBox.cpp
    M Source/WebCore/rendering/RenderFragmentContainer.cpp
    M Source/WebCore/rendering/RenderGrid.cpp
    M Source/WebCore/rendering/RenderImage.cpp
    M Source/WebCore/rendering/RenderLayer.cpp
    M Source/WebCore/rendering/RenderLayer.h
    M Source/WebCore/rendering/RenderLayerBacking.cpp
    M Source/WebCore/rendering/RenderLayerCompositor.cpp
    M Source/WebCore/rendering/RenderLayerModelObject.cpp
    M Source/WebCore/rendering/RenderLayerModelObject.h
    M Source/WebCore/rendering/RenderLayoutState.cpp
    M Source/WebCore/rendering/RenderObject.cpp
    M Source/WebCore/rendering/RenderObject.h
    M Source/WebCore/rendering/RenderTable.cpp
    M Source/WebCore/rendering/RenderTableRow.cpp
    M Source/WebCore/rendering/RenderTableSection.cpp
    M Source/WebCore/rendering/RenderView.cpp
    M Source/WebCore/rendering/svg/RenderSVGModelObject.cpp
    M Source/WebCore/rendering/svg/SVGBoundingBoxComputation.cpp
    M Source/WebKitLegacy/mac/DOM/DOMUIKitExtensions.mm

  Log Message:
  -----------
  Rename hasTransform() to isTransformed() on RenderObject and RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=250909

Reviewed by Simon Fraser.

The name "hasTransform" is kind of convoluted in WebCore due to historically denoting on
RenderStyle whether a "transform" property was set to some non-none value. With the
addition of more CSS properties affecting transform, and the addition of
RenderStyle::affectsTransform(), we should also rename "hasTransform" on
RenderLayer and RenderObject to be "isTransformed" to better match what this
method denotes.

* Source/WebCore/display/css/DisplayBox.h:
* Source/WebCore/rendering/BackgroundPainter.cpp:
(WebCore::BackgroundPainter::calculateBackgroundImageGeometry):
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::simplifiedLayout):
(WebCore::RenderBlock::isSelectionRoot const):
(WebCore::RenderBlock::selectionGaps):
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutBlock):
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::isCandidateForOpaquenessTest):
(WebCore::RenderBox::layoutOverflowRectForPropagation const):
* Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
* Source/WebCore/rendering/RenderFragmentContainer.cpp:
(WebCore::RenderFragmentContainer::layoutOverflowRectForBoxForPropagation):
* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutBlock):
* Source/WebCore/rendering/RenderImage.cpp:
(WebCore::RenderImage::layoutShadowContent):
* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateTransform):
(WebCore::RenderLayer::updatePagination):
(WebCore::RenderLayer::cannotBlitToWindow const):
(WebCore::transparencyClipBox):
(WebCore::RenderLayer::collectFragments):
* Source/WebCore/rendering/RenderLayer.h:
(WebCore::RenderLayer::canUseOffsetFromAncestor const):
(WebCore::RenderLayer::isTransformed const):
(WebCore::RenderLayer::hasTransform const): Deleted.
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateTransform):
(WebCore::layerOrAncestorIsTransformedOrUsingCompositedScrolling):
(WebCore::RenderLayerBacking::getCurrentTransform const):
* Source/WebCore/rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::reasonsForCompositing const):
(WebCore::RenderLayerCompositor::requiresCompositingForTransform const):
* Source/WebCore/rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::styleWillChange):
(WebCore::RenderLayerModelObject::styleDidChange):
(WebCore::RenderLayerModelObject::mapLocalToSVGContainer const):
* Source/WebCore/rendering/RenderLayerModelObject.h:
* Source/WebCore/rendering/RenderLayoutState.cpp:
(WebCore::shouldDisablePaintOffsetCacheForSubtree):
* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::RenderObject::shouldUseTransformFromContainer const):
(WebCore::RenderObject::pushOntoGeometryMap const):
(WebCore::RenderObject::offsetFromAncestorContainer const):
* Source/WebCore/rendering/RenderObject.h:
(WebCore::RenderObject::isTransformed const):
(WebCore::RenderObject::hasTransformOrPerspective const):
(WebCore::RenderObject::hasTransform const): Deleted.
* Source/WebCore/rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):
* Source/WebCore/rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::layout):
* Source/WebCore/rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layout):
(WebCore::RenderTableSection::layoutRows):
* Source/WebCore/rendering/RenderView.cpp:
(WebCore::RenderView::documentRect const):
* Source/WebCore/rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::mapAbsoluteToLocalPoint const):
* Source/WebCore/rendering/svg/SVGBoundingBoxComputation.cpp:
(WebCore::SVGBoundingBoxComputation::handleRootOrContainer const):
* Source/WebKitLegacy/mac/DOM/DOMUIKitExtensions.mm:
(-[DOMHTMLElement structuralComplexityContribution]):

Canonical link: https://commits.webkit.org/259171@main