[webkit-changes] [WebKit/WebKit] 65c06f: REGRESSION(257730 at main): [GTK] WebGL 2 not available

Michael Catanzaro noreply at github.com
Wed Jan 18 16:18:37 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 65c06fc0f3086176505a2350e5f2db726cba8bbd
      https://github.com/WebKit/WebKit/commit/65c06fc0f3086176505a2350e5f2db726cba8bbd
  Author: Michael Catanzaro <mcatanzaro at redhat.com>
  Date:   2023-01-18 (Wed, 18 Jan 2023)

  Changed paths:
    M Source/cmake/OptionsGTK.cmake

  Log Message:
  -----------
  REGRESSION(257730 at main): [GTK] WebGL 2 not available
https://bugs.webkit.org/show_bug.cgi?id=250708

Reviewed by Adrian Perez de Castro and Alejandro G. Castro.

Currently ENABLE_WEBGL2 is OFF by default even though USE_OPENGL_OR_ES
is ON. Problem is the value is tested before it is defined. It's not
safe to use the values of standard options until after
WEBKIT_OPTION_END. Instead, we should declare a dependency.

This also drive-by relocates a misplaced comment.

* Source/cmake/OptionsGTK.cmake:

Canonical link: https://commits.webkit.org/259059@main




More information about the webkit-changes mailing list