[webkit-changes] [WebKit/WebKit] d783b5: REGRESSION (250910 at main): [ macOS wk1 ] fast/canva...

Jean-Yves Avenard noreply at github.com
Wed Jan 18 15:52:44 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d783b5c13cf92d178837e054f56eef867e89bb65
      https://github.com/WebKit/WebKit/commit/d783b5c13cf92d178837e054f56eef867e89bb65
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2023-01-18 (Wed, 18 Jan 2023)

  Changed paths:
    M LayoutTests/fast/canvas/canvas-createPattern-video-loading.html
    M LayoutTests/platform/mac-wk1/TestExpectations

  Log Message:
  -----------
  REGRESSION (250910 at main): [ macOS wk1 ] fast/canvas/canvas-createPattern-video-loading.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=244336
rdar://99140960

Reviewed by Eric Carlson and Youenn Fablet.

Prior the rewrite using video.requestVideoFrameCallback, the test would simply seek to currentTime = 1s.
The video doesn't have a frame at 1s, they are located at 0.996s and 1.021678s on either side of 1s.

The test checks a particular location of the image that doesn't change over time, as such, there's no much
point waiting for new frames to come.

We can simplify the test and seek to the actual time.

* LayoutTests/fast/canvas/canvas-createPattern-video-loading.html:
* LayoutTests/platform/mac-wk1/TestExpectations:

Canonical link: https://commits.webkit.org/259058@main




More information about the webkit-changes mailing list