[webkit-changes] [WebKit/WebKit] 921f82: Let MediaController.currentTime return the positio...

Ahmad Saleem noreply at github.com
Wed Jan 18 01:23:20 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 921f8243c150a68acf023bd56851540bb1cd8214
      https://github.com/WebKit/WebKit/commit/921f8243c150a68acf023bd56851540bb1cd8214
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-01-18 (Wed, 18 Jan 2023)

  Changed paths:
    M LayoutTests/media/media-controller-playback-expected.txt
    M LayoutTests/media/media-controller-playback.html
    M Source/WebCore/html/MediaController.cpp

  Log Message:
  -----------
  Let MediaController.currentTime return the position previously set

Let MediaController.currentTime return the position previously set
https://bugs.webkit.org/show_bug.cgi?id=250594

Reviewed by Eric Carlson.

This patch is to align WebKit with Web-Specification:

Web-Spec: https://html.spec.whatwg.org/multipage/media.html#seeking

"Set the current playback position to the new playback position."

This patch modifies 'setCurrenTime' function to have "m_position" as "time" and return it according to web-specification.

Merge - http://src.chromium.org/viewvc/blink?view=rev&rev=170504

* Source/WebCore/html/MediaController.cpp:
(MediaController::setCurrentTime): Add 'm_position = time;" for Step 11 of Web-Spec
* LayoutTests/media/media-controller-playback.html: Add new sub-test
* LayoutTests/media/media-controller-playback-expected.txt: Add new sub-test expectations

Canonical link: https://commits.webkit.org/259020@main




More information about the webkit-changes mailing list