[webkit-changes] [WebKit/WebKit] 3612aa: Make sure to reload subresources loaded during the...

youennf noreply at github.com
Wed Jan 18 00:53:12 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3612aa5748ea37b492f8b45541eaaae130877779
      https://github.com/WebKit/WebKit/commit/3612aa5748ea37b492f8b45541eaaae130877779
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2023-01-18 (Wed, 18 Jan 2023)

  Changed paths:
    M LayoutTests/http/tests/inspector/network/har/har-page-aggressive-gc-expected.txt
    M LayoutTests/http/tests/inspector/network/har/har-page-expected.txt
    A LayoutTests/http/wpt/service-workers/cache-mode-hard-reload-serviceworker-expected.txt
    A LayoutTests/http/wpt/service-workers/cache-mode-hard-reload-serviceworker.html
    A LayoutTests/http/wpt/service-workers/cache-mode-hard-reload-serviceworker.js
    A LayoutTests/http/wpt/service-workers/resources/cache-mode-hard-reload-serviceworker.py
    M LayoutTests/platform/mac-wk1/http/tests/inspector/network/har/har-page-expected.txt
    M Source/WebCore/loader/cache/CachedResourceLoader.cpp
    M Source/WebCore/loader/cache/CachedResourceRequest.cpp
    M Source/WebCore/loader/cache/CachedResourceRequest.h
    M Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl
    M Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp
    M Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.h
    M Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
    M Tools/WebKitTestRunner/InjectedBundle/TestRunner.h
    M Tools/WebKitTestRunner/TestController.cpp
    M Tools/WebKitTestRunner/TestController.h
    M Tools/WebKitTestRunner/TestInvocation.cpp

  Log Message:
  -----------
  Make sure to reload subresources loaded during the load of a hard reloaded document
https://bugs.webkit.org/show_bug.cgi?id=250705
rdar://36246099

Reviewed by Alex Christensen.

When doing a page reload from origin, we should ensure to reload from origin the subresources loaded during the initial load.
This is on par with Chrome and Firefox.
To do so, we set the fetch cache to reload in case page is being reloaded from origin.

Add a test that checks through service worker that we set the cache mode of a request accordingly.
Update inspector tests that make use of reload from origin.

* LayoutTests/http/tests/inspector/network/har/har-page-aggressive-gc-expected.txt:
* LayoutTests/http/tests/inspector/network/har/har-page-expected.txt:
* LayoutTests/http/wpt/service-workers/cache-mode-hard-reload-serviceworker-expected.txt: Added.
* LayoutTests/http/wpt/service-workers/cache-mode-hard-reload-serviceworker.html: Added.
* LayoutTests/http/wpt/service-workers/cache-mode-hard-reload-serviceworker.js: Added.
(async doClaim):
(onactivate):
(onfetch.async e):
(onmessage):
* LayoutTests/http/wpt/service-workers/cache-test-serviceworker.html: Added.
* LayoutTests/http/wpt/service-workers/cache-test-serviceworker.js: Added.
(async doClaim):
(onactivate):
(onfetch.async e):
* LayoutTests/http/wpt/service-workers/resources/cache-mode-hard-reload-serviceworker.py: Added.
(main):
* LayoutTests/http/wpt/service-workers/resources/test.py: Added.
(main):
* LayoutTests/platform/mac-wk1/http/tests/inspector/network/har/har-page-expected.txt:
* Source/WebCore/loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::updateHTTPRequestHeaders):
* Source/WebCore/loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::updateCacheModeIfNeeded):
* Source/WebCore/loader/cache/CachedResourceRequest.h:
* Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::reloadFromOrigin):
* Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.h:
* Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::reloadFromOrigin):
* Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:
* Tools/WebKitTestRunner/TestController.cpp:
(WTR::TestController::reloadFromOrigin):
* Tools/WebKitTestRunner/TestController.h:
* Tools/WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

Canonical link: https://commits.webkit.org/259019@main




More information about the webkit-changes mailing list