[webkit-changes] [WebKit/WebKit] b03a81: `appearance: slider-vertical` should only apply to...

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b03a814cfb391bae7eb95a00bb0149aaa1ac8d7b
      https://github.com/WebKit/WebKit/commit/b03a814cfb391bae7eb95a00bb0149aaa1ac8d7b
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2023-01-14 (Sat, 14 Jan 2023)

  Changed paths:
    A LayoutTests/fast/forms/slider-track-not-input-element-expected.html
    R LayoutTests/fast/forms/slider-track-not-input-element-expected.txt
    M LayoutTests/fast/forms/slider-track-not-input-element.html
    M Source/WebCore/rendering/RenderTheme.cpp

  Log Message:
  -----------
  `appearance: slider-vertical` should only apply to range inputs
https://bugs.webkit.org/show_bug.cgi?id=250492
rdar://104147398

Reviewed by Tim Nguyen.

`slider-vertical` is a non-standard `appearance` value, maintained as legacy
`-webkit-appearance` behavior. It is not possible to paint `slider-vertical`
without an `<input type=range>`. However, there is currently logic that guards
against attempts to paint `slider-vertical` for non-range input elements, since
the effective appearance is not always adjusted.

Ensure that `slider-vertical` can only be an effective appearance for range
inputs, and replace checks for range inputs with assertions.

* LayoutTests/fast/forms/slider-track-not-input-element-expected.html: Added.
* LayoutTests/fast/forms/slider-track-not-input-element-expected.txt: Removed.
* LayoutTests/fast/forms/slider-track-not-input-element.html:

Updated crash test to be a reference test.

* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustAppearanceForElement const):
(WebCore::createSliderTrackPartForRenderer):

Canonical link: https://commits.webkit.org/258924@main