[webkit-changes] [WebKit/WebKit] 003ff7: box-shadow does not paint correctly on inline elem...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 003ff7e2ae82907fd161f7725d460de4af7eef68
      https://github.com/WebKit/WebKit/commit/003ff7e2ae82907fd161f7725d460de4af7eef68
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-01-14 (Sat, 14 Jan 2023)

  Changed paths:
    A LayoutTests/fast/repaint/box-shadow-top-left-repaint-expected.txt
    A LayoutTests/fast/repaint/box-shadow-top-left-repaint.html
    M LayoutTests/fast/repaint/full-repaint-on-content-change.html
    M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp

  Log Message:
  -----------
  box-shadow does not paint correctly on inline elements
https://bugs.webkit.org/show_bug.cgi?id=250059
<rdar://problem/103887993>

Reviewed by Antti Koivisto.

Box shadow top and left values are relative to the content box. Shadow on the top/left side of the box produce negative values.
Calling FloatRect::inflate with negative values deflate the rect.
Also, use physical (visual) variants of the RenderStyle box-shadow functions as at this point (display box phase) all the coord are in physical (visual) space.

* LayoutTests/fast/repaint/box-shadow-top-left-repaint-expected.txt: Added.
* LayoutTests/fast/repaint/box-shadow-top-left-repaint.html: Added.
* LayoutTests/fast/repaint/full-repaint-on-content-change.html: (remove odd leftover)
* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::computeInkOverflowForInlineLevelBox):

Canonical link: https://commits.webkit.org/258923@main