[webkit-changes] [WebKit/WebKit] cebb09: VibrationActuator should limit the duration of vib...

Chris Dumez noreply at github.com
Tue Jan 10 17:37:44 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cebb0928942f5aaa233f202f1dc99fe4fd8565c1
      https://github.com/WebKit/WebKit/commit/cebb0928942f5aaa233f202f1dc99fe4fd8565c1
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-01-10 (Tue, 10 Jan 2023)

  Changed paths:
    M Source/WebCore/Modules/gamepad/GamepadEffectParameters.h
    M Source/WebCore/Modules/gamepad/GamepadHapticActuator.cpp
    M Source/WebCore/platform/gamepad/cocoa/GameControllerHapticEffect.mm

  Log Message:
  -----------
  VibrationActuator should limit the duration of vibration effects
https://bugs.webkit.org/show_bug.cgi?id=250415

Reviewed by Brent Fulgham.

VibrationActuator should limit the duration of vibration effects:
- https://w3c.github.io/gamepad/extensions.html#gamepadeffectparameters-dictionary

The specification recommends a maximum of 5 seconds.

* Source/WebCore/Modules/gamepad/GamepadEffectParameters.h:
* Source/WebCore/Modules/gamepad/GamepadHapticActuator.cpp:
(WebCore::GamepadHapticActuator::playEffect):
* Source/WebCore/platform/gamepad/cocoa/GameControllerHapticEffect.mm:
(WebCore::GameControllerHapticEffect::create):

Canonical link: https://commits.webkit.org/258759@main




More information about the webkit-changes mailing list