[webkit-changes] [WebKit/WebKit] 4eaf82: Gamepad.vibrationActuator.type should be "dual-rum...

Chris Dumez noreply at github.com
Tue Jan 10 17:32:38 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4eaf82bc0732bda0d63b7886f7e3647df6405d01
      https://github.com/WebKit/WebKit/commit/4eaf82bc0732bda0d63b7886f7e3647df6405d01
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-01-10 (Tue, 10 Jan 2023)

  Changed paths:
    A LayoutTests/gamepad/gamepad-vibrationActuator-type-expected.txt
    A LayoutTests/gamepad/gamepad-vibrationActuator-type.html
    M Source/WebCore/Modules/gamepad/Gamepad.cpp
    M Source/WebCore/Modules/gamepad/GamepadHapticActuator.cpp
    M Source/WebCore/Modules/gamepad/GamepadHapticActuator.h

  Log Message:
  -----------
  Gamepad.vibrationActuator.type should be "dual-rumble"
https://bugs.webkit.org/show_bug.cgi?id=250410

Reviewed by Alex Christensen.

Gamepad.vibrationActuator.type should be "dual-rumble", not "vibration":
- https://w3c.github.io/gamepad/extensions.html#dom-gamepadhapticactuatortype

* LayoutTests/gamepad/gamepad-vibrationActuator-type-expected.txt: Added.
* LayoutTests/gamepad/gamepad-vibrationActuator-type.html: Added.
* Source/WebCore/Modules/gamepad/Gamepad.cpp:
(WebCore::Gamepad::vibrationActuator):
* Source/WebCore/Modules/gamepad/GamepadHapticActuator.cpp:
(WebCore::GamepadHapticActuator::create):
(WebCore::GamepadHapticActuator::GamepadHapticActuator):
* Source/WebCore/Modules/gamepad/GamepadHapticActuator.h:

Canonical link: https://commits.webkit.org/258758@main




More information about the webkit-changes mailing list