[webkit-changes] [WebKit/WebKit] 929973: Fix ASSERT crash in masonry-grid-template-columns-...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 929973a6b81a666841b16576a184e7d45edd610b
      https://github.com/WebKit/WebKit/commit/929973a6b81a666841b16576a184e7d45edd610b
  Author: Brandon Stewart <brandonstewart at apple.com>
  Date:   2023-01-09 (Mon, 09 Jan 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/masonry-grid-template-columns-computed-withcontent-expected.txt
    M Source/WebCore/rendering/RenderGrid.cpp

  Log Message:
  -----------
  Fix ASSERT crash in masonry-grid-template-columns-computed-withcontent.html
https://bugs.webkit.org/show_bug.cgi?id=250349

Reviewed by Matt Woodrow.

This test case was crashing due to an assert being triggered by m_autoRepeatTotalTracks being set to 0
in OrderedNamedLinesCollectorInGridLayout::collectLineNamesForIndex. The crash is caused by
set needs items placement, which was reseting the auto repeat tracks. We never set them again leading to the
crash later on.

* LayoutTests/TestExpectations:
* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::RenderGrid::placeItemsOnGrid):

Canonical link: https://commits.webkit.org/258700@main