[webkit-changes] [WebKit/WebKit] 5e5f36: [JSC] Fix elem.wast.js failures

Yusuke Suzuki noreply at github.com
Mon Jan 9 20:41:49 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5e5f363e84a288599d15d273e9386f2429712232
      https://github.com/WebKit/WebKit/commit/5e5f363e84a288599d15d273e9386f2429712232
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2023-01-09 (Mon, 09 Jan 2023)

  Changed paths:
    M JSTests/wasm/references/externref_table.js
    M JSTests/wasm/references/multitable.js
    M JSTests/wasm/spec-tests/elem.wast.js
    M Source/JavaScriptCore/wasm/WasmFormat.cpp
    M Source/JavaScriptCore/wasm/WasmFormat.h
    M Source/JavaScriptCore/wasm/WasmFunctionParser.h
    M Source/JavaScriptCore/wasm/WasmSectionParser.cpp
    M Source/JavaScriptCore/wasm/WasmSectionParser.h

  Log Message:
  -----------
  [JSC] Fix elem.wast.js failures
https://bugs.webkit.org/show_bug.cgi?id=250323
rdar://104031204

Reviewed by Keith Miller.

This patch fixes remaining elem.wast.js failures.

1. table.init's table and element should have the same type.
2. element can take externref. We update our implementation on parsing code (previously, only funcref is allowed).

* JSTests/wasm/spec-tests/elem.wast.js:
* Source/JavaScriptCore/wasm/WasmFormat.cpp:
(WTF::printInternal):
* Source/JavaScriptCore/wasm/WasmFormat.h:
* Source/JavaScriptCore/wasm/WasmFunctionParser.h:
(JSC::Wasm::FunctionParser<Context>::parseExpression):
* Source/JavaScriptCore/wasm/WasmSectionParser.cpp:
(JSC::Wasm::SectionParser::parseElement):
(JSC::Wasm::SectionParser::validateElementTableIdx):
(JSC::Wasm::SectionParser::parseElementSegmentVectorOfExpressions):
* Source/JavaScriptCore/wasm/WasmSectionParser.h:

Canonical link: https://commits.webkit.org/258699@main




More information about the webkit-changes mailing list