[webkit-changes] [WebKit/WebKit] 223758: Cherry-pick c7f1532632f7. rdar://problem/103973520
Chris Dumez
noreply at github.com
Mon Jan 9 14:39:36 PST 2023
Branch: refs/heads/safari-7615.1.18-branch
Home: https://github.com/WebKit/WebKit
Commit: 223758ea4b4b30a72c1b6ae7f9b08a05058fa81c
https://github.com/WebKit/WebKit/commit/223758ea4b4b30a72c1b6ae7f9b08a05058fa81c
Author: Chris Dumez <cdumez at apple.com>
Date: 2023-01-09 (Mon, 09 Jan 2023)
Changed paths:
M Source/WebCore/Modules/gamepad/GamepadHapticEffectType.h
M Source/WebCore/Modules/gamepad/GamepadHapticEffectType.idl
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
A Source/WebCore/platform/gamepad/cocoa/CoreHapticsSoftLink.h
A Source/WebCore/platform/gamepad/cocoa/CoreHapticsSoftLink.mm
M Source/WebCore/platform/gamepad/cocoa/GameControllerGamepad.h
M Source/WebCore/platform/gamepad/cocoa/GameControllerGamepad.mm
M Source/WebCore/platform/gamepad/cocoa/GameControllerGamepadProvider.mm
A Source/WebCore/platform/gamepad/cocoa/GameControllerHapticEffect.h
A Source/WebCore/platform/gamepad/cocoa/GameControllerHapticEffect.mm
A Source/WebCore/platform/gamepad/cocoa/GameControllerHapticEngines.h
A Source/WebCore/platform/gamepad/cocoa/GameControllerHapticEngines.mm
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
Log Message:
-----------
Cherry-pick c7f1532632f7. rdar://problem/103973520
Make Gamepad.vibrationActuator work with the GameController framework
https://bugs.webkit.org/show_bug.cgi?id=250217
rdar://problem/103973520
Reviewed by Brady Eidson.
Make Gamepad.vibrationActuator work with the GameController framework, so that
the gamepad now actually vibrates on macOS 13+.
This was tested manually using an XBox controller.
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/platform/gamepad/cocoa/CoreHapticsSoftLink.h: Added.
* Source/WebCore/platform/gamepad/cocoa/CoreHapticsSoftLink.mm: Added.
* Source/WebCore/platform/gamepad/cocoa/GameControllerGamepad.h:
* Source/WebCore/platform/gamepad/cocoa/GameControllerGamepad.mm:
(WebCore::GameControllerGamepad::ensureHapticEngines):
(WebCore::GameControllerGamepad::playEffect):
(WebCore::GameControllerGamepad::stopEffects):
(WebCore::GameControllerGamepad::noLongerHasAnyClient):
* Source/WebCore/platform/gamepad/cocoa/GameControllerGamepadProvider.mm:
(WebCore::GameControllerGamepadProvider::stopMonitoringGamepads):
* Source/WebCore/platform/gamepad/cocoa/GameControllerHapticEffect.h: Copied from Source/WebCore/platform/gamepad/cocoa/GameControllerGamepad.h.
* Source/WebCore/platform/gamepad/cocoa/GameControllerHapticEffect.mm: Added.
(WebCore::GameControllerHapticEffect::create):
(WebCore::GameControllerHapticEffect::GameControllerHapticEffect):
(WebCore::GameControllerHapticEffect::~GameControllerHapticEffect):
(WebCore::GameControllerHapticEffect::start):
(WebCore::GameControllerHapticEffect::stop):
(WebCore::GameControllerHapticEffect::strongEffectFinishedPlaying):
(WebCore::GameControllerHapticEffect::weakEffectFinishedPlaying):
* Source/WebCore/platform/gamepad/cocoa/GameControllerHapticEngines.h: Copied from Source/WebCore/platform/gamepad/cocoa/GameControllerGamepad.h.
(WebCore::GameControllerHapticEngines::strongEngine):
(WebCore::GameControllerHapticEngines::weakEngine):
* Source/WebCore/platform/gamepad/cocoa/GameControllerHapticEngines.mm: Added.
(WebCore::GameControllerHapticEngines::create):
(WebCore::GameControllerHapticEngines::GameControllerHapticEngines):
(WebCore::GameControllerHapticEngines::playEffect):
(WebCore::GameControllerHapticEngines::stopEffects):
(WebCore::GameControllerHapticEngines::ensureStarted):
(WebCore::GameControllerHapticEngines::stop):
Canonical link: https://commits.webkit.org/258674@main
Canonical link: https://commits.webkit.org/258608.4@safari-7615.1.18-branch
Commit: 7b0662540123b0f241c8df6576fa694b98f21994
https://github.com/WebKit/WebKit/commit/7b0662540123b0f241c8df6576fa694b98f21994
Author: Chris Dumez <cdumez at apple.com>
Date: 2023-01-09 (Mon, 09 Jan 2023)
Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebKit/Shared/WebPreferencesDefaultValues.cpp
M Source/WebKit/Shared/WebPreferencesDefaultValues.h
Log Message:
-----------
Cherry-pick 3120ab92ddc5. rdar://problem/103423250
Gamepad API - add support for vibrationActuator
https://bugs.webkit.org/show_bug.cgi?id=248989
rdar://103423250
Reviewed by Brady Eidson and Alex Christensen.
Turn on support for Gamepad.vibrationActuator on macOS 13+ now that it is
supported on this platform.
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebKit/Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultGamepadVibrationActuatorEnabled):
* Source/WebKit/Shared/WebPreferencesDefaultValues.h:
Canonical link: https://commits.webkit.org/258680@main
Canonical link: https://commits.webkit.org/258608.5@safari-7615.1.18-branch
Compare: https://github.com/WebKit/WebKit/compare/2b5fadaa8df4...7b0662540123
More information about the webkit-changes
mailing list