[webkit-changes] [WebKit/WebKit] c14ea6: REGRESSION(258522 at main): Ensure the slider style i...

[Said Abou-Hallawa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c14ea6ce8716cee385610874385c04417621068c
      https://github.com/WebKit/WebKit/commit/c14ea6ce8716cee385610874385c04417621068c
  Author: Said Abou-Hallawa <said at apple.com>
  Date:   2023-01-09 (Mon, 09 Jan 2023)

  Changed paths:
    A LayoutTests/fast/forms/slider-track-not-input-element-expected.txt
    A LayoutTests/fast/forms/slider-track-not-input-element.html
    M Source/WebCore/rendering/RenderTheme.cpp

  Log Message:
  -----------
  REGRESSION(258522 at main): Ensure the slider style is applied to an <input> element before drawing
https://bugs.webkit.org/show_bug.cgi?id=250334
rdar://104019874

Reviewed by Aditya Keerthi.

The appearance style can be applied to any non <input> element. In 258522 at main,
createSliderTrackPartForRenderer() was refactored from RenderTheme::paintSliderTicks()
which makes an early return "if (!is<HTMLInputElement>(o.node()))". We need to
port this check to createSliderTrackPartForRenderer().

* LayoutTests/fast/forms/slider-track-not-input-element-expected.txt: Added.
* LayoutTests/fast/forms/slider-track-not-input-element.html: Added.
* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::createSliderTrackPartForRenderer):

Canonical link: https://commits.webkit.org/258684@main