[webkit-changes] [WebKit/WebKit] a7cb32: [GPU Process] [FormControls] Add a ControlPart for...

Said Abou-Hallawa noreply at github.com
Thu Jan 5 23:29:59 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a7cb32dd78298add87a55300a4a8992401cbf253
      https://github.com/WebKit/WebKit/commit/a7cb32dd78298add87a55300a4a8992401cbf253
  Author: Said Abou-Hallawa <said at apple.com>
  Date:   2023-01-05 (Thu, 05 Jan 2023)

  Changed paths:
    M Source/WebCore/Headers.cmake
    M Source/WebCore/SourcesCocoa.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/platform/graphics/controls/ControlFactory.h
    A Source/WebCore/platform/graphics/controls/InnerSpinButtonPart.h
    M Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.h
    M Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.mm
    A Source/WebCore/platform/graphics/mac/controls/InnerSpinButtonMac.h
    A Source/WebCore/platform/graphics/mac/controls/InnerSpinButtonMac.mm
    M Source/WebCore/platform/graphics/mac/controls/MeterMac.h
    M Source/WebCore/platform/mac/ThemeMac.mm
    M Source/WebCore/rendering/RenderTheme.cpp
    M Source/WebCore/rendering/RenderThemeMac.mm
    M Source/WebKit/Shared/WebCoreArgumentCoders.cpp

  Log Message:
  -----------
  [GPU Process] [FormControls] Add a ControlPart for InnerSpinButton
https://bugs.webkit.org/show_bug.cgi?id=249885
rdar://103697514

Reviewed by Aditya Keerthi.

The InnerSpinButtonPart will handle drawing the stepper control part which is
displayed for the (<input type="number">) form control. On macOS, AppKit will
be used to draw the platform control through the class InnerSpinButtonMac.

* Source/WebCore/Headers.cmake:
* Source/WebCore/SourcesCocoa.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/platform/graphics/controls/ControlFactory.h:
* Source/WebCore/platform/graphics/controls/InnerSpinButtonPart.h: Copied from Source/WebCore/platform/graphics/mac/controls/MeterMac.h.
* Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.h:
* Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.mm:
(WebCore::ControlFactoryMac::createPlatformInnerSpinButton):
* Source/WebCore/platform/graphics/mac/controls/InnerSpinButtonMac.h: Copied from Source/WebCore/platform/graphics/mac/controls/MeterMac.h.
* Source/WebCore/platform/graphics/mac/controls/InnerSpinButtonMac.mm: Added.
(WebCore::InnerSpinButtonMac::InnerSpinButtonMac):
(WebCore::InnerSpinButtonMac::cellSize const):
(WebCore::InnerSpinButtonMac::draw):
* Source/WebCore/platform/graphics/mac/controls/MeterMac.h:
* Source/WebCore/platform/mac/ThemeMac.mm:
(WebCore::ThemeMac::paint):
(WebCore::paintStepper): Deleted.
* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::createControlPart const):
* Source/WebCore/rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::canPaint const):
(WebCore::RenderThemeMac::canCreateControlPartForRenderer const):
* Source/WebKit/Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<ControlPart>::decode):

Canonical link: https://commits.webkit.org/258525@main




More information about the webkit-changes mailing list