[webkit-changes] [WebKit/WebKit] bfe244: Remove CSSLogicalEnabled preference

Tim Nguyen noreply at github.com
Thu Jan 5 23:49:49 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bfe2441d9e38a24d34f9bf9a8de6a19b07dd20a6
      https://github.com/WebKit/WebKit/commit/bfe2441d9e38a24d34f9bf9a8de6a19b07dd20a6
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2023-01-05 (Thu, 05 Jan 2023)

  Changed paths:
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebCore/page/DeprecatedGlobalSettings.h
    M Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
    M Source/WebKitLegacy/mac/WebView/WebPreferences.mm
    M Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h
    M Tools/DumpRenderTree/TestOptions.cpp

  Log Message:
  -----------
  Remove CSSLogicalEnabled preference
https://bugs.webkit.org/show_bug.cgi?id=250165
rdar://103936550

Reviewed by Brent Fulgham.

The preference doesn't do anything.

Also, CSS Logical properties and values have shipped for a while.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/page/DeprecatedGlobalSettings.h:
(WebCore::DeprecatedGlobalSettings::setCSSLogicalEnabled): Deleted.
(WebCore::DeprecatedGlobalSettings::cssLogicalEnabled): Deleted.
* Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h:
* Source/WebKitLegacy/mac/WebView/WebPreferences.mm:
(-[WebPreferences cssLogicalEnabled]): Deleted.
(-[WebPreferences setCSSLogicalEnabled:]): Deleted.
* Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h:
* Tools/DumpRenderTree/TestOptions.cpp:
(WTR::TestOptions::defaults):

Canonical link: https://commits.webkit.org/258526@main




More information about the webkit-changes mailing list