[webkit-changes] [WebKit/WebKit] f9b389: [GPU Process] [FormControls] Add ControlPart for M...
Said Abou-Hallawa
noreply at github.com
Wed Jan 4 15:14:26 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f9b389be95cc3dc8143bbedd82fd530a1f2bcaaf
https://github.com/WebKit/WebKit/commit/f9b389be95cc3dc8143bbedd82fd530a1f2bcaaf
Author: Said Abou-Hallawa <said at apple.com>
Date: 2023-01-04 (Wed, 04 Jan 2023)
Changed paths:
M Source/WebCore/Headers.cmake
M Source/WebCore/SourcesCocoa.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/platform/graphics/controls/ControlFactory.h
A Source/WebCore/platform/graphics/controls/MenuListPart.h
M Source/WebCore/platform/graphics/mac/controls/ButtonControlMac.mm
M Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.h
M Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.mm
M Source/WebCore/platform/graphics/mac/controls/ControlMac.h
M Source/WebCore/platform/graphics/mac/controls/ControlMac.mm
A Source/WebCore/platform/graphics/mac/controls/MenuListMac.h
A Source/WebCore/platform/graphics/mac/controls/MenuListMac.mm
M Source/WebCore/platform/mediastream/mac/ScreenCaptureKitSharingSessionManager.h
M Source/WebCore/rendering/RenderTheme.cpp
M Source/WebCore/rendering/RenderThemeMac.h
M Source/WebCore/rendering/RenderThemeMac.mm
M Source/WebKit/Shared/WebCoreArgumentCoders.cpp
Log Message:
-----------
[GPU Process] [FormControls] Add ControlPart for MenuList
https://bugs.webkit.org/show_bug.cgi?id=249978
rdar://103795005
Reviewed by Aditya Keerthi.
This ControlPart will handle drawing the MenuList form control (i.e. <select>...</select>).
For macOS, AppKit will be used to draw the platform control.
* Source/WebCore/Headers.cmake:
* Source/WebCore/SourcesCocoa.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/platform/graphics/controls/ControlFactory.h:
* Source/WebCore/platform/graphics/controls/MenuListPart.h: Copied from Source/WebCore/platform/graphics/controls/ControlFactory.h.
* Source/WebCore/platform/graphics/mac/controls/ButtonControlMac.mm:
(WebCore::ButtonControlMac::updateCellStates):
* Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.h:
* Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.mm:
(WebCore::ControlFactoryMac::checkboxCell const):
(WebCore::ControlFactoryMac::radioCell const):
(WebCore::ControlFactoryMac::levelIndicatorCell const):
(WebCore::ControlFactoryMac::popUpButtonCell const):
(WebCore::ControlFactoryMac::createPlatformMenuList):
* Source/WebCore/platform/graphics/mac/controls/ControlMac.h:
* Source/WebCore/platform/graphics/mac/controls/ControlMac.mm:
(WebCore::ControlMac::updateCheckedState):
(WebCore::ControlMac::updateEnabledState):
(WebCore::ControlMac::updateFocusedState):
(WebCore::ControlMac::updatePressedState):
* Source/WebCore/platform/graphics/mac/controls/MenuListMac.h: Copied from Source/WebCore/platform/graphics/controls/ControlFactory.h.
* Source/WebCore/platform/graphics/mac/controls/MenuListMac.mm: Added.
(WebCore::MenuListMac::MenuListMac):
(WebCore::MenuListMac::cellSize const):
(WebCore::MenuListMac::cellOutsets const):
(WebCore::MenuListMac::updateCellStates):
(WebCore::MenuListMac::rectForBounds const):
(WebCore::MenuListMac::draw):
* Source/WebCore/platform/mediastream/mac/ScreenCaptureKitSharingSessionManager.h:
* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::createControlPart const):
* Source/WebCore/rendering/RenderThemeMac.h:
* Source/WebCore/rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::canPaint const):
(WebCore::RenderThemeMac::canCreateControlPartForRenderer const):
(WebCore::RenderThemeMac::paintMenuList): Deleted.
* Source/WebKit/Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<ControlPart>::decode):
Canonical link: https://commits.webkit.org/258453@main
More information about the webkit-changes
mailing list