[webkit-changes] [WebKit/WebKit] 5e0958: Minimum effective device width changes made during...
Tim Horton
noreply at github.com
Wed Jan 4 15:01:42 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5e095859bb52ed952a47f2f09b3a1b25445304a0
https://github.com/WebKit/WebKit/commit/5e095859bb52ed952a47f2f09b3a1b25445304a0
Author: Tim Horton <timothy_horton at apple.com>
Date: 2023-01-04 (Wed, 04 Jan 2023)
Changed paths:
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h
M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.h
M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm
Log Message:
-----------
Minimum effective device width changes made during live-ish resize take effect immediately
https://bugs.webkit.org/show_bug.cgi?id=250097
rdar://103884357
Reviewed by Wenson Hsieh and Dean Jackson.
While in live-ish resize, layout parameter changes are supposed to be deferred
until the resize completes. However, eb491a86 missed deferring
minimumEffectiveDeviceWidth changes.
Expose _shouldDeferGeometryUpdates internally and use that to defer mEDW changes.
Also ensure that we actually dispatch mEDW changes once the resize completes,
even if the view layout size didn't change.
Add a test that ensures that this all works.
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _setMinimumEffectiveDeviceWidth:]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h:
* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.h:
* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView _dispatchSetViewLayoutSize:]):
(-[WKWebView _didStopDeferringGeometryUpdates]):
(-[WKWebView _beginAnimatedResizeWithUpdates:]):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
(TEST):
Canonical link: https://commits.webkit.org/258452@main
More information about the webkit-changes
mailing list